[webkit-changes] [WebKit/WebKit] 610c7d: [git-webkit] Avoid listing all branches for old co...

Jonathan Bedard noreply at github.com
Thu Apr 20 12:49:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 610c7d596fb76241053115a77a3dedba8948e87a
      https://github.com/WebKit/WebKit/commit/610c7d596fb76241053115a77a3dedba8948e87a
  Author: Jonathan Bedard <jbedard at apple.com>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    M Tools/Scripts/libraries/webkitscmpy/setup.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py
    M Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py

  Log Message:
  -----------
  [git-webkit] Avoid listing all branches for old commits
https://bugs.webkit.org/show_bug.cgi?id=255737
rdar://108328653

Reviewed by Dewei Zhu.

For very old commits, listing all branches those commits are members of
can be very expensive. It's also a fairly wasteful operation, most commits
are on `main`, so we should quickly check that case first before attempting
the more general case.

* Tools/Scripts/libraries/webkitscmpy/setup.py: Bump version.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/__init__.py: Ditto.
* Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/git.py:
(Git._is_on_default_branch): Directly check if a commit is on the default branch.
(Git.commit): Attempt to directly check if a commit is on the default branch before
listing all branches for a commit.

Canonical link: https://commits.webkit.org/263190@main




More information about the webkit-changes mailing list