[webkit-changes] [WebKit/WebKit] dd75c5: [WebGPU] Consistently handle pipeline layouts

Tadeu Zagallo noreply at github.com
Thu Apr 20 01:17:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: dd75c5c12d617264cfc1e26a70c94591e4eb67c1
      https://github.com/WebKit/WebKit/commit/dd75c5c12d617264cfc1e26a70c94591e4eb67c1
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    M Source/WebGPU/WGSL/GlobalVariableRewriter.cpp
    M Source/WebGPU/WGSL/GlobalVariableRewriter.h
    M Source/WebGPU/WGSL/WGSL.cpp
    M Source/WebGPU/WGSL/WGSL.h
    M Source/WebGPU/WebGPU/RenderPipeline.mm
    M Source/WebGPU/WebGPU/ShaderModule.mm

  Log Message:
  -----------
  [WebGPU] Consistently handle pipeline layouts
https://bugs.webkit.org/show_bug.cgi?id=255659
rdar://108265709

Reviewed by Mike Wyrzykowski.

Early compilation was initializing `auto` layouts as empty WGSL::PipelineLayout and
deferred compilation as an empty optional layout. Change the code to consistently
represent it as the empty optional everywhere.

* Source/WebGPU/WGSL/GlobalVariableRewriter.cpp:
(WGSL::RewriteGlobalVariables::RewriteGlobalVariables):
(WGSL::rewriteGlobalVariables):
* Source/WebGPU/WGSL/GlobalVariableRewriter.h:
* Source/WebGPU/WGSL/WGSL.cpp:
(WGSL::prepareImpl):
(WGSL::prepare):
* Source/WebGPU/WGSL/WGSL.h:
* Source/WebGPU/WebGPU/RenderPipeline.mm:
(WebGPU::Device::createRenderPipeline):
* Source/WebGPU/WebGPU/ShaderModule.mm:
(WebGPU::earlyCompileShaderModule):

Canonical link: https://commits.webkit.org/263168@main




More information about the webkit-changes mailing list