[webkit-changes] [WebKit/WebKit] e8be4e: [WGSL] Serialize global overrides

Tadeu Zagallo noreply at github.com
Thu Apr 20 01:05:32 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e8be4ea461d38fbc0c474eae04c13a20552e16d8
      https://github.com/WebKit/WebKit/commit/e8be4ea461d38fbc0c474eae04c13a20552e16d8
  Author: Tadeu Zagallo <tzagallo at apple.com>
  Date:   2023-04-20 (Thu, 20 Apr 2023)

  Changed paths:
    M Source/WebGPU/WGSL/MangleNames.cpp
    M Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp

  Log Message:
  -----------
  [WGSL] Serialize global overrides
https://bugs.webkit.org/show_bug.cgi?id=255600
rdar://108197601

Reviewed by Myles C. Maxfield.

Add serialization support for override declarations. Notice that we temporarily
disable the mangling of globals, which ironically wasn't being used yet, but
requires notifying the API about the mangling. I will be implementing that next
and will re-enable the mangling.

* Source/WebGPU/WGSL/MangleNames.cpp:
(WGSL::NameManglerVisitor::visit):
* Source/WebGPU/WGSL/Metal/MetalFunctionWriter.cpp:
(WGSL::Metal::FunctionDefinitionWriter::write):
(WGSL::Metal::FunctionDefinitionWriter::visit):
(WGSL::Metal::FunctionDefinitionWriter::visitGlobal):
(WGSL::Metal::FunctionDefinitionWriter::serializeVariable):

Canonical link: https://commits.webkit.org/263167@main




More information about the webkit-changes mailing list