[webkit-changes] [WebKit/WebKit] f7dc48: (iOS) Dragging the selection in Live Text far away...

Richard Robinson noreply at github.com
Mon Apr 17 19:07:33 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: f7dc489cf43a47d7fb881fcbead613205f16513d
      https://github.com/WebKit/WebKit/commit/f7dc489cf43a47d7fb881fcbead613205f16513d
  Author: Richard Robinson <richard_robinson2 at apple.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    M Source/WebCore/rendering/RenderObject.cpp

  Log Message:
  -----------
  (iOS) Dragging the selection in Live Text far away sometimes causes a crash
https://bugs.webkit.org/show_bug.cgi?id=255566
rdar://108169157

Reviewed by Wenson Hsieh.

When selecting text with Live Text, if the selection contains different writing modes, a crash
can occur when collecting the selection geometries if the ancestor does not have a renderer.

This PR fixes this by adding a null check for the existence of a renderer.

* Source/WebCore/rendering/RenderObject.cpp:
(WebCore::RenderObject::collectSelectionGeometriesInternal):

Canonical link: https://commits.webkit.org/263053@main




More information about the webkit-changes mailing list