[webkit-changes] [WebKit/WebKit] a6b2a5: Rendering issue with checkbox in flexbox layout

Alan Baradlay noreply at github.com
Mon Apr 17 19:06:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a6b2a57ab860a07f1c2c89c8cd98b4a34212e645
      https://github.com/WebKit/WebKit/commit/a6b2a57ab860a07f1c2c89c8cd98b4a34212e645
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    A LayoutTests/fast/flexbox/overlapped-form-controls-expected.html
    A LayoutTests/fast/flexbox/overlapped-form-controls.html
    R LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/css/css-flexbox/radiobutton-min-size-expected.txt
    M Source/WebCore/platform/Theme.cpp
    M Source/WebCore/rendering/RenderThemeIOS.h
    M Source/WebCore/rendering/RenderThemeIOS.mm

  Log Message:
  -----------
  Rendering issue with checkbox in flexbox layout
https://bugs.webkit.org/show_bug.cgi?id=255419
<rdar://problem/108026194>

Reviewed by Antti Koivisto.

Form controls with appearance are supposed to set their minimum (intrinsic) widths so that they don't get overlapped (e.g. by getting sized to 0px)
in over-constrained situations.

* LayoutTests/fast/flexbox/overlapped-form-controls-expected.html: Added.
* LayoutTests/fast/flexbox/overlapped-form-controls.html: Added.
* Source/WebCore/platform/Theme.cpp:
(WebCore::Theme::minimumControlSize const):

Canonical link: https://commits.webkit.org/263052@main




More information about the webkit-changes mailing list