[webkit-changes] [WebKit/WebKit] 61e71f: [GStreamer] fast/speechsynthesis/speech-synthesis-...

Philippe Normand noreply at github.com
Mon Apr 17 03:19:08 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 61e71fb6931bc84319aa55dfeeeedc6028db640a
      https://github.com/WebKit/WebKit/commit/61e71fb6931bc84319aa55dfeeeedc6028db640a
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    M Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp

  Log Message:
  -----------
  [GStreamer] fast/speechsynthesis/speech-synthesis-utterance-uses-voice.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=255483

Reviewed by Xabier Rodriguez-Calvar.

Store the PlatformSpeechSynthesizer as a const reference in the GStreamer wrapper in order to avoid
a strong reference cycle.

* Source/WebCore/platform/gstreamer/PlatformSpeechSynthesizerGStreamer.cpp:
(WebCore::GstSpeechSynthesisWrapper::GstSpeechSynthesisWrapper):
(WebCore::GstSpeechSynthesisWrapper::pause):
(WebCore::GstSpeechSynthesisWrapper::resume):
(WebCore::GstSpeechSynthesisWrapper::speakUtterance):
(WebCore::GstSpeechSynthesisWrapper::cancel):
(WebCore::PlatformSpeechSynthesizer::speak):

Canonical link: https://commits.webkit.org/263021@main




More information about the webkit-changes mailing list