[webkit-changes] [WebKit/WebKit] 027ba3: [GStreamer][WebRTC] Offer/Answer handling is poten...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 027ba321f4ed77460ee52d0a67734d93f5c651ab
      https://github.com/WebKit/WebKit/commit/027ba321f4ed77460ee52d0a67734d93f5c651ab
  Author: Philippe Normand <philn at igalia.com>
  Date:   2023-04-17 (Mon, 17 Apr 2023)

  Changed paths:
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp
    M Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h

  Log Message:
  -----------
  [GStreamer][WebRTC] Offer/Answer handling is potentially racy
https://bugs.webkit.org/show_bug.cgi?id=255284

Reviewed by Xabier Rodriguez-Calvar.

The RTCSdpType corresponding to either offer or answer the end-point is managing is now stored in
the GStreamerMediaEndpointHolder. We were previously using an un-protected boolean member variable
for this but storing the information in the holder passed to the webrtcbin create-{offer,answer}
signal handler is safer.

* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.cpp:
(WebCore::GStreamerMediaEndpoint::initiate):
(WebCore::GStreamerMediaEndpoint::createSessionDescriptionSucceeded):
(WebCore::GStreamerMediaEndpoint::createSessionDescriptionFailed):
* Source/WebCore/Modules/mediastream/gstreamer/GStreamerMediaEndpoint.h:

Canonical link: https://commits.webkit.org/263020@main