[webkit-changes] [WebKit/WebKit] b87766: Start using origin directory for DOMCache and Serv...

Sihui noreply at github.com
Thu Apr 13 20:29:52 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b877662f6f561a6cdffee42c6ed5bd2781033ffd
      https://github.com/WebKit/WebKit/commit/b877662f6f561a6cdffee42c6ed5bd2781033ffd
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h
    M Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp
    M Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp
    M Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm
    M Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm

  Log Message:
  -----------
  Start using origin directory for DOMCache and ServiceWorkerRegistrations
https://bugs.webkit.org/show_bug.cgi?id=255349
rdar://107843591

Reviewed by Youenn Fablet.

By moving to UnifiedOriginStorageLevel::Standard, NetworkStorageManager will migrate existing DOMCache and
ServiceWorkerRegistrations data to origin directory and start using origin directory for storage.

This patch also fixes an issue that DOMCache path is set to be empty string when OriginStorageManager starts using
UnifiedOriginStorageLevel::Standard and there is no existing data to migrate at old path.

* Source/WebKit/NetworkProcess/NetworkSessionCreationParameters.h:
* Source/WebKit/NetworkProcess/storage/NetworkStorageManager.cpp:
(WebKit::NetworkStorageManager::lastModificationTimeForOrigin const):
* Source/WebKit/NetworkProcess/storage/OriginStorageManager.cpp:
(WebKit::OriginStorageManager::StorageBucket::resolvedCacheStoragePath):
* Source/WebKit/UIProcess/WebsiteData/Cocoa/WebsiteDataStoreCocoa.mm: Some tests rely on custom CacheStorage and
ServiceWorkerRegistrations and paths, so we keep using UnifiedOriginStorageLevel::Basic for them.
(WebKit::WebsiteDataStore::defaultUnifiedOriginStorageLevel):
* Tools/TestWebKitAPI/Tests/WebKitCocoa/ServiceWorkerBasic.mm: Ditto.

Canonical link: https://commits.webkit.org/262941@main




More information about the webkit-changes mailing list