[webkit-changes] [WebKit/WebKit] 9a0e88: Screen orientation type should be counter-clockwise

Marcos Cáceres noreply at github.com
Thu Apr 13 18:12:58 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9a0e8865a0f5906ce4150ca7617743d030ad4d40
      https://github.com/WebKit/WebKit/commit/9a0e8865a0f5906ce4150ca7617743d030ad4d40
  Author: Marcos Caceres <marcos at marcosc.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading.html
    M LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt
    M Source/WebCore/platform/ios/ScreenOrientationProviderIOS.mm
    M Source/WebKit/UIProcess/ios/PageClientImplIOS.mm
    M Tools/WebKitTestRunner/ios/TestControllerIOS.mm

  Log Message:
  -----------
  Screen orientation type should be counter-clockwise
https://bugs.webkit.org/show_bug.cgi?id=255388
rdar://107976966

Reviewed by Chris Dumez.

Now reports "landscape-primary" when the device is turned to the left and
"landscape-secondary" when the device is turned to the right. This matches
the behavior of the other platforms and aligns with the updated W3C Spec:
https://github.com/w3c/screen-orientation/pull/248

* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading.html:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt:
* Source/WebCore/platform/ios/ScreenOrientationProviderIOS.mm:
(WebCore::ScreenOrientationProvider::platformCurrentOrientation):
* Tools/WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::lockScreenOrientation):

* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/screen-orientation/orientation-reading.html:
* LayoutTests/platform/ios/imported/w3c/web-platform-tests/screen-orientation/orientation-reading-expected.txt:
* Source/WebCore/platform/ios/ScreenOrientationProviderIOS.mm:
(WebCore::ScreenOrientationProvider::platformCurrentOrientation):
* Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:
(WebKit::toUIInterfaceOrientationMask):
* Tools/WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::lockScreenOrientation):

Canonical link: https://commits.webkit.org/262940@main




More information about the webkit-changes mailing list