[webkit-changes] [WebKit/WebKit] 05766a: [IFC] All inline level boxes should have layout bo...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 05766a3d72ccd9ea9740dd450b9f4a484d746051
      https://github.com/WebKit/WebKit/commit/05766a3d72ccd9ea9740dd450b9f4a484d746051
  Author: Alan Baradlay <zalan at apple.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp

  Log Message:
  -----------
  [IFC] All inline level boxes should have layout bounds
https://bugs.webkit.org/show_bug.cgi?id=255336

Reviewed by Antti Koivisto.

This is in preparation for merging InlineLevelBox's ascent/descent and layoutBounds to reduce code complexity.

In this patch we ensure that layout bounds is available on non-inline box type of inline level boxes (this is aligned with the CSS spec).

* Source/WebCore/layout/formattingContexts/inline/InlineLevelBox.h:
(WebCore::Layout::InlineLevelBox::layoutBounds const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxBuilder.cpp:
(WebCore::Layout::LineBoxBuilder::setVerticalPropertiesForInlineLevelBox const):
(WebCore::Layout::LineBoxBuilder::constructInlineLevelBoxes):
(WebCore::Layout::LineBoxBuilder::adjustInlineBoxHeightsForLineBoxContainIfApplicable):
(WebCore::Layout::LineBoxBuilder::adjustIdeographicBaselineIfApplicable):
(WebCore::Layout::LineBoxBuilder::computeLineBoxGeometry const):
* Source/WebCore/layout/formattingContexts/inline/InlineLineBoxVerticalAligner.cpp:
(WebCore::Layout::LineBoxVerticalAligner::computeLogicalHeightAndAlign const):
(WebCore::Layout::LineBoxVerticalAligner::simplifiedVerticalAlignment const):
(WebCore::Layout::LineBoxVerticalAligner::computeLineBoxLogicalHeight const):
(WebCore::Layout::LineBoxVerticalAligner::computeRootInlineBoxVerticalPosition const):
(WebCore::Layout::LineBoxVerticalAligner::layoutBoundsForInlineBoxSubtree const):
(WebCore::Layout::LineBoxVerticalAligner::alignInlineLevelBoxes const):
(WebCore::Layout::LineBoxVerticalAligner::adjustForAnnotationIfNeeded const):

Canonical link: https://commits.webkit.org/262910@main