[webkit-changes] [WebKit/WebKit] d02c05: WKWebView alert window is truncating title

[youennf]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: d02c05b3862111d6ae974f65d3a8288dfb0acc24
      https://github.com/WebKit/WebKit/commit/d02c05b3862111d6ae974f65d3a8288dfb0acc24
  Author: Youenn Fablet <youennf at gmail.com>
  Date:   2023-04-13 (Thu, 13 Apr 2023)

  Changed paths:
    M Source/WebKit/SourcesCocoa.txt
    M Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm
    M Source/WebKit/UIProcess/Cocoa/MediaPermissionUtilities.mm
    M Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm
    A Source/WebKit/UIProcess/ios/UIAlertControllerUtilities.h
    A Source/WebKit/UIProcess/ios/UIAlertControllerUtilities.mm
    M Source/WebKit/UIProcess/ios/WKPasswordView.mm
    M Source/WebKit/UIProcess/ios/WKWebGeolocationPolicyDeciderIOS.mm
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj

  Log Message:
  -----------
  WKWebView alert window is truncating title
https://bugs.webkit.org/show_bug.cgi?id=254958
rdar://106327229

Reviewed by Jean-Yves Avenard.

Introduce a routine to create an alert dialog which is not truncating very long titles.
Use it wherever alerts are created in UIProcess code.

Manually tested.

* Source/WebKit/SourcesCocoa.txt:
* Source/WebKit/UIProcess/API/ios/WKWebViewIOS.mm:
(-[WKWebView _presentLockdownMode]):
* Source/WebKit/UIProcess/Cocoa/MediaPermissionUtilities.mm:
(WebKit::alertForPermission):
* Source/WebKit/UIProcess/Cocoa/WKStorageAccessAlert.mm:
(WebKit::displayStorageAccessAlert):
* Source/WebKit/UIProcess/ios/UIAlertControllerUtilities.h: Added.
* Source/WebKit/UIProcess/ios/UIAlertControllerUtilities.mm: Added.
(WebKit::createUIAlertController):
* Source/WebKit/UIProcess/ios/WKPasswordView.mm:
(-[WKPasswordView showPasswordFailureAlert]):
* Source/WebKit/UIProcess/ios/WKWebGeolocationPolicyDeciderIOS.mm:
(-[WKWebGeolocationPolicyDecider _executeNextChallenge]):
* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController _showPhishingAlert]):
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:

Canonical link: https://commits.webkit.org/262909@main