[webkit-changes] [WebKit/WebKit] 226c80: Speculative fix for PS Release build
Ross Kirsling
noreply at github.com
Mon Apr 10 01:55:48 PDT 2023
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 226c809b2e6b2461435b10075fdd24410dce2cea
https://github.com/WebKit/WebKit/commit/226c809b2e6b2461435b10075fdd24410dce2cea
Author: Ross Kirsling <rkirsling at gmail.com>
Date: 2023-04-10 (Mon, 10 Apr 2023)
Changed paths:
M Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_combined_implementation.py
M Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_internals_wrapper_implementation.py
M Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_implementation.py
M Source/WebCore/bindings/js/JSDOMGlobalObjectInlines.h
Log Message:
-----------
Speculative fix for PS Release build
https://bugs.webkit.org/show_bug.cgi?id=255217
Unreviewed build fix.
Following 262755 at main, PS Release yet again has a linking error like:
Link : error: L0039: reference to undefined symbol `JSC::JSObject::didBecomePrototype()'
This happens in WebCoreJSBuiltins.cpp when new IDL is added and...that's literally all we ever know, but the fix is
generally to upgrade StructureInlines.h to JSObjectInlines.h *somewhere*.
It is clear that 260052 at main was not aggressive enough in upgrading the includes in the builtins generator scripts,
so let's go further this time.
* Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_combined_implementation.py:
* Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_internals_wrapper_implementation.py:
* Source/JavaScriptCore/Scripts/wkbuiltins/builtins_generate_separate_implementation.py:
* Source/WebCore/bindings/js/JSDOMGlobalObjectInlines.h:
Canonical link: https://commits.webkit.org/262765@main
More information about the webkit-changes
mailing list