[webkit-changes] [WebKit/WebKit] a1dda9: [popover] Rename :open to :popover-open and remove...

Mon Apr 10 00:23:21 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: a1dda9cba6d90bf99b4f4e82898dd2d17acd9f8f
      https://github.com/WebKit/WebKit/commit/a1dda9cba6d90bf99b4f4e82898dd2d17acd9f8f
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2023-04-10 (Mon, 10 Apr 2023)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/hide-other-popover-side-effects.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/light-dismiss-event-ordering.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nesting.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-document-open.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-events.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-child-dialog.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hidden-display.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-inside-display-none.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-invoking-attribute.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-on-scroll.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-not-keyboard-focusable.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-removal-2.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-removal.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-shadow-dom.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-stacking.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-element-disabled.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-combinations.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-interactions.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-types-with-hints.tentative.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-types.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-utils.js
    M LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt
    M Source/WebCore/css/CSSSelector.cpp
    M Source/WebCore/css/CSSSelector.h
    M Source/WebCore/css/SelectorChecker.cpp
    M Source/WebCore/css/SelectorCheckerTestFunctions.h
    M Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in
    M Source/WebCore/css/popover.css
    M Source/WebCore/cssjit/SelectorCompiler.cpp
    M Source/WebCore/html/HTMLElement.cpp

  Log Message:
  -----------
  [popover] Rename :open to :popover-open and remove :closed
https://bugs.webkit.org/show_bug.cgi?id=254816

Reviewed by Tim Nguyen.

Remove the support for :open/:closed and add support for :popover-open.

Import the adjusted WPT tests based on:
https://github.com/web-platform-tests/wpt/commit/c751476c04678faa79e598683f2a6e94d17cf9e0

* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/hide-other-popover-side-effects.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/light-dismiss-event-ordering.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-anchor-nesting.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-document-open.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-events.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-2.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus-child-dialog.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-focus.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-hidden-display.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-inside-display-none.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-invoking-attribute.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss-on-scroll.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-light-dismiss.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-not-keyboard-focusable.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-removal-2.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-removal.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-shadow-dom.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-stacking.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-target-element-disabled.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-combinations.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-top-layer-interactions.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-types-with-hints.tentative.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/popover-types.html:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/popovers/resources/popover-utils.js:
(showDefaultopenPopoversOnLoad.show):
(showDefaultopenPopoversOnLoad):
(assertPopoverVisibility):
* LayoutTests/platform/ios-wk2/imported/w3c/web-platform-tests/html/semantics/popovers/popover-attribute-basic-expected.txt:
* Source/WebCore/css/CSSSelector.cpp:
(WebCore::CSSSelector::selectorText const):
* Source/WebCore/css/CSSSelector.h:
* Source/WebCore/css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne const):
* Source/WebCore/css/SelectorCheckerTestFunctions.h:
(WebCore::matchesPopoverOpenPseudoClass):
(WebCore::matchesOpenPseudoClass): Deleted.
(WebCore::matchesClosedPseudoClass): Deleted.
* Source/WebCore/css/SelectorPseudoClassAndCompatibilityElementMap.in:
* Source/WebCore/css/popover.css:
(@namespace "http://www.w3.org/1999/xhtml";):
(dialog:popover-open):
([popover]:popover-open::backdrop):
(dialog[popover]:not(:closed)): Deleted.
([popover]:open::backdrop): Deleted.
* Source/WebCore/cssjit/SelectorCompiler.cpp:
(WebCore::SelectorCompiler::JSC_DEFINE_JIT_OPERATION):
(WebCore::SelectorCompiler::addPseudoClassType):
* Source/WebCore/html/HTMLElement.cpp:
(WebCore::HTMLElement::showPopover):
(WebCore::HTMLElement::hidePopoverInternal):
(WebCore::HTMLElement::popoverAttributeChanged):

Canonical link: https://commits.webkit.org/262764@main