[webkit-changes] [WebKit/WebKit] 952f3c: document.open() should abort all loads when the do...

Chris Dumez noreply at github.com
Tue Sep 20 16:42:17 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 952f3c7c8ab8baa4279db4a804712201c998c389
      https://github.com/WebKit/WebKit/commit/952f3c7c8ab8baa4279db4a804712201c998c389
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-09-20 (Tue, 20 Sep 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-refresh-immediate.window-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-while-navigating.window-expected.txt
    A LayoutTests/platform/mac-wk1/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-while-navigating.window-expected.txt
    M Source/WebCore/dom/Document.cpp
    M Source/WebCore/loader/NavigationScheduler.cpp
    M Source/WebCore/loader/NavigationScheduler.h

  Log Message:
  -----------
  document.open() should abort all loads when the document is navigating
https://bugs.webkit.org/show_bug.cgi?id=245407

Reviewed by Youenn Fablet.

document.open() should abort all loads when the document is navigating or there is a queued navigation:
- https://github.com/whatwg/html/issues/3975

This aligns our behavior with Blink and Gecko, as they already already passing those WPT tests.

* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-refresh-immediate.window-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/abort-while-navigating.window-expected.txt:
* Source/WebCore/dom/Document.cpp:
(WebCore::Document::open):
* Source/WebCore/loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::hasQueuedNavigation const):
* Source/WebCore/loader/NavigationScheduler.h:

Canonical link: https://commits.webkit.org/254699@main




More information about the webkit-changes mailing list