[webkit-changes] [WebKit/WebKit] bef8de: 'select' controls doesn't render size=2 or size=3 ...

[Ahmad Saleem]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: bef8deafdcd33a5cdd4c4e08f894c3bc61416544
      https://github.com/WebKit/WebKit/commit/bef8deafdcd33a5cdd4c4e08f894c3bc61416544
  Author: Ahmad Saleem <ahmad.saleem792+github at gmail.com>
  Date:   2022-09-20 (Tue, 20 Sep 2022)

  Changed paths:
    M LayoutTests/fast/events/select-element.html
    M LayoutTests/fast/forms/select-clientheight-with-multiple-attr-expected.txt
    M LayoutTests/fast/forms/select-clientheight-with-multiple-attr.html
    M LayoutTests/fast/scrolling/scroll-select-list-expected.html
    M LayoutTests/fast/scrolling/scroll-select-list.html
    M LayoutTests/platform/gtk/fast/forms/disabled-select-change-index-expected.png
    M LayoutTests/platform/gtk/fast/forms/disabled-select-change-index-expected.txt
    M LayoutTests/platform/gtk/fast/forms/listbox-bidi-align-expected.png
    M LayoutTests/platform/gtk/fast/forms/listbox-bidi-align-expected.txt
    M LayoutTests/platform/gtk/fast/replaced/replaced-breaking-expected.png
    M LayoutTests/platform/gtk/fast/replaced/replaced-breaking-expected.txt
    M LayoutTests/platform/gtk/fast/text/international/bidi-listbox-atsui-expected.png
    M LayoutTests/platform/gtk/fast/text/international/bidi-listbox-atsui-expected.txt
    M LayoutTests/platform/gtk/fast/text/international/bidi-listbox-expected.png
    M LayoutTests/platform/gtk/fast/text/international/bidi-listbox-expected.txt
    M LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.png
    M LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt
    M LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.png
    M LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt
    M LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.png
    M LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt
    M LayoutTests/platform/mac/fast/text/international/bidi-listbox-atsui-expected.png
    M LayoutTests/platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt
    M LayoutTests/platform/mac/fast/text/international/bidi-listbox-expected.png
    M LayoutTests/platform/mac/fast/text/international/bidi-listbox-expected.txt
    M Source/WebCore/rendering/RenderListBox.cpp

  Log Message:
  -----------
  'select' controls doesn't render size=2 or size=3 properly

'select' controls doesn't render size=2 or size=3 properly

https://bugs.webkit.org/show_bug.cgi?id=28900

Reviewed by Aditya Keerthi.

Merge - https://src.chromium.org/viewvc/blink?revision=182276&view=revision

Support size<4 rendering of listbox <select> by removing fixed length and updating "size" return value.

* Source/WebCore/rendering/RenderListBox.cpp: Remove minimum size value of 4
(RenderListBox::size): Change "return" after removing fixed minimum size
* LayoutTests/fast/events/select-element.html: Updated Test Case
* LayoutTests/fast/forms/select-clientheight-with-multiple-attr.html: Updated Test Case
* LayoutTests/fast/forms/select-clientheight-with-multiple-attr-expected.txt: Updated Test Expectations
* LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.png: Updated Test Expectations
* LayoutTests/platform/mac/fast/forms/disabled-select-change-index-expected.txt: Updated Test Expectations
* LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.txt: Updated Test Expectations
* LayoutTests/platform/mac/fast/forms/listbox-bidi-align-expected.png: Updated Test Expectations
* LayoutTests/platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt: Updated Test Expectations
* LayoutTests/platform/mac/fast/text/international/bidi-listbox-atsui-expected.png: Updated Test Expectations
* LayoutTests/platform/mac/fast/text/international/bidi-listbox-expected.png: Updated Test Expectations
* LayoutTests/platform/mac/fast/text/international/bidi-listbox-expected.txt: Updated Test Expectations
* LayoutTests/platform/gtk/fast/forms/disabled-select-chagne-index-expected.png: Updated Test Expectations
* LayoutTests/platform/gtk/fast/forms/disabled-select-chagne-index-expected.txt: Updated Test Expectations
* LayoutTests/platform/gtk/fast/forms/listbox-bidi-align-expected.png: Updated Test Expectations
* LayoutTests/platform/gtk/fast/forms/listbox-bidi-align-expected.txt: Updated Test Expectations
* LayoutTests/platform/gtk/fast/replaced/replaced-breaking-expected.png: Updated Test Expectations
* LayoutTests/platform/gtk/fast/replaced/replaced-breaking-expected.txt: Updated Test Expectations
* LayoutTests/platform/gtk/fast/text/international/bidi-listbox-atsui-expected.txt: Updated Test Expectations
* LayoutTests/platform/gtk/fast/text/international/bidi-listbox-atsui-expected.png: Updated Test Expectations
* LayoutTests/platform/gtk/fast/text/international/bidi-listbox-expected.png: Updated Test Expectations
* LayoutTests/platform/gtk/fast/text/international/bidi-listbox-expected.txt: Updated Test Expectations
* LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.png: Updated Test Expectations
* LayoutTests/platform/mac/fast/replaced/replaced-breaking-expected.txt: Updated Test Expectations
* LayoutTests/fast/scrolling/scroll-select-list-expected.html: Updated to "size 4" of select list
* LayoutTests/fast/scrolling/scroll-select-list.html: Updated to "size 4" of select list

Canonical link: https://commits.webkit.org/254698@main