[webkit-changes] [WebKit/WebKit] 13be91: Scroll To Text Fragment Indicator flashes though b...

megangardner noreply at github.com
Wed Sep 14 15:39:06 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 13be919f4512dc3771840c699abf5389bbe422e9
      https://github.com/WebKit/WebKit/commit/13be919f4512dc3771840c699abf5389bbe422e9
  Author: Megan Gardner <megan_gardner at apple.com>
  Date:   2022-09-14 (Wed, 14 Sep 2022)

  Changed paths:
    M Source/WebCore/page/FrameView.cpp

  Log Message:
  -----------
  Scroll To Text Fragment Indicator flashes though banners.
https://bugs.webkit.org/show_bug.cgi?id=245116
rdar://99669383

Reviewed by Tim Horton.

The text indicator is flashing through banners that are over the text at the time of
flash. In order to stop this, check the edge of the indicator and do not start it if
either end is occluded. This does not deal with popups that show up part way through
the flash of the indicator.

* Source/WebCore/page/FrameView.cpp:
(WebCore::FrameView::textFragmentIndicatorTimerFired):

Canonical link: https://commits.webkit.org/254494@main




More information about the webkit-changes mailing list