[webkit-changes] [WebKit/WebKit] 3b0345: html/browsers/browsing-the-web/history-traversal/p...

Chris Dumez noreply at github.com
Wed Sep 14 15:24:50 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3b0345e4d4e277783583964c2ff3b9697c5aa1cc
      https://github.com/WebKit/WebKit/commit/3b0345e4d4e277783583964c2ff3b9697c5aa1cc
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-09-14 (Wed, 14 Sep 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc-expected.txt
    M Source/WebCore/loader/FrameLoader.cpp

  Log Message:
  -----------
  html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc.html is failing in WebKit
https://bugs.webkit.org/show_bug.cgi?id=245163

Reviewed by Brent Fulgham.

The issue was that the loadType would get ignored in FrameLoader::loadItem()
when the navigation is same-document. As a result, m_loadType wouldn't get
set and FrameLoader::scrollToFragmentWithParentBoundary() would call
isSameDocumentReload() with an inaccurate loadType.

* LayoutTests/imported/w3c/web-platform-tests/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/scroll-restoration-fragment-scrolling-samedoc-expected.txt:
* Source/WebCore/loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem):

Canonical link: https://commits.webkit.org/254493@main




More information about the webkit-changes mailing list