[webkit-changes] [WebKit/WebKit] 2f9d01: Use std::optional for IDBResourceIdentifier in IDB...

Sihui noreply at github.com
Mon Sep 12 13:09:12 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2f9d01af63cb2f223c20b9bb2a87c99539da2997
      https://github.com/WebKit/WebKit/commit/2f9d01af63cb2f223c20b9bb2a87c99539da2997
  Author: Sihui Liu <sihui_liu at apple.com>
  Date:   2022-09-12 (Mon, 12 Sep 2022)

  Changed paths:
    M Source/WebCore/Modules/indexeddb/client/TransactionOperation.cpp
    M Source/WebCore/Modules/indexeddb/client/TransactionOperation.h
    M Source/WebCore/Modules/indexeddb/shared/IDBRequestData.cpp
    M Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h
    M Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h
    M Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in

  Log Message:
  -----------
  Use std::optional for IDBResourceIdentifier in IDBRequestData and TransactionOperation
https://bugs.webkit.org/show_bug.cgi?id=244996

Reviewed by Chris Dumez.

IDBResourceIdentifier is small enough and members in IDBRequestData and TransactionOperation are not changed after
initialization.

* Source/WebCore/Modules/indexeddb/client/TransactionOperation.cpp:
(WebCore::IDBClient::TransactionOperation::TransactionOperation):
* Source/WebCore/Modules/indexeddb/client/TransactionOperation.h:
(WebCore::IDBClient::TransactionOperation::cursorIdentifier const):
* Source/WebCore/Modules/indexeddb/shared/IDBRequestData.cpp:
(WebCore::IDBRequestData::IDBRequestData):
(WebCore::IDBRequestData::isolatedCopy):
(WebCore::IDBRequestData::requestIdentifier const):
(WebCore::IDBRequestData::databaseIdentifier const):
* Source/WebCore/Modules/indexeddb/shared/IDBRequestData.h:
(WebCore::IDBRequestData::IDBRequestData): Deleted.
(WebCore::IDBRequestData::databaseIdentifier const): Deleted.
* Source/WebCore/Modules/indexeddb/shared/IDBResourceIdentifier.h:
* Source/WebKit/Shared/WebCoreArgumentCoders.serialization.in:

Canonical link: https://commits.webkit.org/254402@main




More information about the webkit-changes mailing list