[webkit-changes] [WebKit/WebKit] 782c4b: Move box shadow painting out of render tree

Antti Koivisto noreply at github.com
Mon Sep 12 13:05:28 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 782c4bbb354fa2b77d5747c1cd9c9a5cdb6069ec
      https://github.com/WebKit/WebKit/commit/782c4bbb354fa2b77d5747c1cd9c9a5cdb6069ec
  Author: Antti Koivisto <antti at apple.com>
  Date:   2022-09-12 (Mon, 12 Sep 2022)

  Changed paths:
    M Source/WebCore/rendering/BackgroundPainter.cpp
    M Source/WebCore/rendering/BackgroundPainter.h
    M Source/WebCore/rendering/InlineBoxPainter.cpp
    M Source/WebCore/rendering/RenderBox.cpp
    M Source/WebCore/rendering/RenderBox.h
    M Source/WebCore/rendering/RenderBoxModelObject.cpp
    M Source/WebCore/rendering/RenderBoxModelObject.h
    M Source/WebCore/rendering/RenderImage.cpp
    M Source/WebCore/rendering/RenderImage.h
    M Source/WebCore/rendering/RenderLayerBacking.cpp
    M Source/WebCore/rendering/RenderTable.cpp
    M Source/WebCore/rendering/RenderTableCell.cpp
    M Source/WebCore/rendering/RenderTableCell.h

  Log Message:
  -----------
  Move box shadow painting out of render tree
https://bugs.webkit.org/show_bug.cgi?id=245065
<rdar://99812600>

Reviewed by Alan Bujtas.

Move it to the BackgroundPainter.

* Source/WebCore/rendering/BackgroundPainter.cpp:
(WebCore::BackgroundPainter::paintBackground):

Also move some more background painting functions.

(WebCore::BackgroundPainter::paintRootBoxFillLayers):
(WebCore::BackgroundPainter::paintsOwnBackground):
(WebCore::BackgroundPainter::paintFillLayer):
(WebCore::areaCastingShadowInHole):
(WebCore::BackgroundPainter::paintBoxShadow):
(WebCore::BackgroundPainter::boxShadowShouldBeAppliedToBackground):
* Source/WebCore/rendering/BackgroundPainter.h:
* Source/WebCore/rendering/BorderPainter.cpp:
(WebCore::BorderPainter::allCornersClippedOut):
(WebCore::allCornersClippedOut): Deleted.
(WebCore::areaCastingShadowInHole): Deleted.
(WebCore::BorderPainter::paintBoxShadow): Deleted.
* Source/WebCore/rendering/BorderPainter.h:
* Source/WebCore/rendering/InlineBoxPainter.cpp:
(WebCore::InlineBoxPainter::paintDecorations):
(WebCore::InlineBoxPainter::paintBoxShadow):
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::RenderBox::paintBoxDecorations):
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect const):
(WebCore::RenderBox::paintRootBoxFillLayers): Deleted.
(WebCore::RenderBox::paintsOwnBackground const): Deleted.
(WebCore::RenderBox::paintBackground): Deleted.
* Source/WebCore/rendering/RenderBox.h:
* Source/WebCore/rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::boxShadowShouldBeAppliedToBackground const): Deleted.
* Source/WebCore/rendering/RenderBoxModelObject.h:
* Source/WebCore/rendering/RenderImage.cpp:
(WebCore::RenderImage::boxShadowShouldBeAppliedToBackground const): Deleted.
* Source/WebCore/rendering/RenderImage.h:
* Source/WebCore/rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDirectlyCompositedBackgroundColor):
* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::paintBoxDecorations):
* Source/WebCore/rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paintBoxDecorations):
(WebCore::RenderTableCell::boxShadowShouldBeAppliedToBackground const): Deleted.
* Source/WebCore/rendering/RenderTableCell.h:

Canonical link: https://commits.webkit.org/254401@main




More information about the webkit-changes mailing list