[webkit-changes] [WebKit/WebKit] 652e0b: [LFC][IFC] Introduce InlineDisplay::Box:isVisible

alan noreply at github.com
Fri Sep 9 13:57:35 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 652e0bfdf0d75898db241f971155445563948a07
      https://github.com/WebKit/WebKit/commit/652e0bfdf0d75898db241f971155445563948a07
  Author: Alan Bujtas <zalan at apple.com>
  Date:   2022-09-09 (Fri, 09 Sep 2022)

  Changed paths:
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h
    M Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp
    M Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h
    M Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp
    M Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp

  Log Message:
  -----------
  [LFC][IFC] Introduce InlineDisplay::Box:isVisible
https://bugs.webkit.org/show_bug.cgi?id=244957

Reviewed by Antti Koivisto.

Let's propagate RenderStyle::visibility bit to InlineDisplay::Box and combine it with text-overflow truncation. It is used for both painting and hittesting.
This patch also flips isVisuallyHidden to isVisible.

* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayBox.h:
(WebCore::InlineDisplay::Box::Text::partiallyVisibleContentLength const):
(WebCore::InlineDisplay::Box::Box):
(WebCore::InlineDisplay::Box::isVisible const):
(WebCore::InlineDisplay::Box::Text::Text):
(WebCore::InlineDisplay::Box::Text::visuallyVisibleLength const): Deleted.
(WebCore::InlineDisplay::Box::isVisuallyHidden const): Deleted.
* Source/WebCore/layout/formattingContexts/inline/display/InlineDisplayContentBuilder.cpp:
(WebCore::Layout::InlineDisplayContentBuilder::appendTextDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendAtomicInlineLevelDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendSpanningInlineBoxDisplayBox):
(WebCore::Layout::InlineDisplayContentBuilder::appendInlineDisplayBoxAtBidiBoundary):
* Source/WebCore/layout/integration/inline/InlineIteratorBoxModernPath.h:
(WebCore::InlineIterator::BoxModernPath::selectableRange const):
* Source/WebCore/layout/integration/inline/LayoutIntegrationInlineContentPainter.cpp:
(WebCore::LayoutIntegration::InlineContentPainter::paintDisplayBox):
* Source/WebCore/layout/integration/inline/LayoutIntegrationLineLayout.cpp:
(WebCore::LayoutIntegration::LineLayout::hitTest):

Canonical link: https://commits.webkit.org/254325@main




More information about the webkit-changes mailing list