[webkit-changes] [WebKit/WebKit] 1787f6: Add over-constrained direction check to computePos...

[Rob Buis]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1787f669ccb1b28a5a723b9dc222551a9028cfd6
      https://github.com/WebKit/WebKit/commit/1787f669ccb1b28a5a723b9dc222551a9028cfd6
  Author: Rob Buis <rbuis at igalia.com>
  Date:   2022-09-09 (Fri, 09 Sep 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/ios/TestExpectations
    M Source/WebCore/rendering/RenderBox.cpp

  Log Message:
  -----------
  Add over-constrained direction check to computePositionedLogicalHeightUsing
https://bugs.webkit.org/show_bug.cgi?id=232012

Reviewed by Darin Adler.

In computePositionedLogicalHeightUsing the over-constrained case never took into
account RTL direction, but this should be done if we are actually dealing with left/right properties. [1]
Finally, computeLogicalTopPositionedOffset should not do the flipping logic in the over-constrained case.

[1] http://www.w3.org/TR/css-writing-modes-3/#vertical-layout

* LayoutTests/TestExpectations:
* LayoutTests/platform/ios/TestExpectations:
* Source/WebCore/rendering/RenderBox.cpp:
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeightUsing const):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced const):

Canonical link: https://commits.webkit.org/254324@main