[webkit-changes] [WebKit/WebKit] 32c097: KVO exception under WebAVPictureInPictureControlle...

[Tim Horton]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 32c0971e6d80908d0a4d8ac06165c619ba6afe63
      https://github.com/WebKit/WebKit/commit/32c0971e6d80908d0a4d8ac06165c619ba6afe63
  Author: Tim Horton <timothy_horton at apple.com>
  Date:   2022-09-08 (Thu, 08 Sep 2022)

  Changed paths:
    M Source/WebCore/platform/cocoa/VideoFullscreenInterfacePiP.mm

  Log Message:
  -----------
  KVO exception under WebAVPictureInPictureController stopPictureInPicture
https://bugs.webkit.org/show_bug.cgi?id=244949
<rdar://problem/99618553>

Reviewed by Jean-Yves Avenard.

* Source/WebCore/platform/cocoa/VideoFullscreenInterfacePiP.mm:
(-[WebAVPictureInPictureController stopPictureInPicture]):
-removeObserver must be strictly paired, and throws an exception if you
try to remove a nonexistent observer. Only try to remove an observer if
we have one installed (indirectly determined by whether the timer is still
outstanding, exactly as done in -dealloc, and in VideoFullscreenInterfaceAVKit).

Canonical link: https://commits.webkit.org/254288@main