[webkit-changes] [WebKit/WebKit] 40343d: [macOS] <attachment> do not have an icon for iWork...
Devin Rousso
noreply at github.com
Thu Sep 8 15:51:21 PDT 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: 40343da91122046fbe9ffee7a747d0f6e66f5c21
https://github.com/WebKit/WebKit/commit/40343da91122046fbe9ffee7a747d0f6e66f5c21
Author: Devin Rousso <drousso at apple.com>
Date: 2022-09-08 (Thu, 08 Sep 2022)
Changed paths:
M LayoutTests/TestExpectations
A LayoutTests/fast/attachment/mac/attachment-keynote-expected-mismatch.html
A LayoutTests/fast/attachment/mac/attachment-keynote.html
A LayoutTests/fast/attachment/mac/attachment-numbers-expected-mismatch.html
A LayoutTests/fast/attachment/mac/attachment-numbers.html
A LayoutTests/fast/attachment/mac/attachment-pages-expected-mismatch.html
A LayoutTests/fast/attachment/mac/attachment-pages.html
M LayoutTests/platform/mac/TestExpectations
M Source/WebCore/rendering/RenderThemeMac.mm
Log Message:
-----------
[macOS] <attachment> do not have an icon for iWork files
https://bugs.webkit.org/show_bug.cgi?id=244946
<rdar://problem/96467446>
Reviewed by Tim Horton.
250772 at main added logic to ensure that thumbnail drawing for iWork documents is done in the UIProcess.
252627 at main turned off thumbnail drawing.
This change guards the logic added in 250772 at main with the flag that was disabled in 252627 at main,
since thumbnail fetching is no longer used and therefore is not accurate anymore.
* Source/WebCore/rendering/RenderThemeMac.mm:
(WebCore::shouldDrawIcon):
* LayoutTests/fast/attachment/mac/attachment-keynote.html: Added.
* LayoutTests/fast/attachment/mac/attachment-keynote-expected-mismatch.html: Added.
* LayoutTests/fast/attachment/mac/attachment-numbers.html: Added.
* LayoutTests/fast/attachment/mac/attachment-numbers-expected-mismatch.html: Added.
* LayoutTests/fast/attachment/mac/attachment-pages.html: Added.
* LayoutTests/fast/attachment/mac/attachment-pages-expected-mismatch.html: Added.
* LayoutTests/TestExpectations:
* LayoutTests/platform/mac/TestExpectations:
Canonical link: https://commits.webkit.org/254287@main
More information about the webkit-changes
mailing list