[webkit-changes] [WebKit/WebKit] 6e3d38: Merge 254213 at main - Revert 252943 at main for causing...

[Philippe Normand]

  Branch: refs/heads/webkitglib/2.38
  Home:   https://github.com/WebKit/WebKit
  Commit: 6e3d3802382d4630df0fbe09eb966cce43bc8508
      https://github.com/WebKit/WebKit/commit/6e3d3802382d4630df0fbe09eb966cce43bc8508
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-09-07 (Wed, 07 Sep 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    R LayoutTests/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt
    R LayoutTests/fast/dom/HTMLLinkElement/link-preload-load-once.html
    R LayoutTests/fast/dom/HTMLLinkElement/link-stylesheet-load-once-expected.txt
    R LayoutTests/fast/dom/HTMLLinkElement/link-stylesheet-load-once.html
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-load-events-expected.txt
    R LayoutTests/platform/mac-wk1/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt
    R LayoutTests/platform/win/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt
    M Source/WebCore/html/HTMLLinkElement.cpp
    M Source/WebCore/html/HTMLLinkElement.h
    M Source/WebCore/html/LinkRelAttribute.h

  Log Message:
  -----------
  Merge 254213 at main - Revert 252943 at main for causing constant flickering on aa.com

Unreviewed. Reverts 252943 at main.

* LayoutTests/TestExpectations:
* LayoutTests/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt: Removed.
* LayoutTests/fast/dom/HTMLLinkElement/link-preload-load-once.html: Removed.
* LayoutTests/fast/dom/HTMLLinkElement/link-stylesheet-load-once-expected.txt: Removed.
* LayoutTests/fast/dom/HTMLLinkElement/link-stylesheet-load-once.html: Removed.
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-error-events-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-multiple-load-events-expected.txt:
* LayoutTests/platform/mac-wk1/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt: Removed.
* LayoutTests/platform/win/fast/dom/HTMLLinkElement/link-preload-load-once-expected.txt: Removed.
* Source/WebCore/html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
(WebCore::HTMLLinkElement::parseAttribute):
(WebCore::HTMLLinkElement::notifyLoadedSheetAndAllCriticalSubresources):
* Source/WebCore/html/HTMLLinkElement.h:
* Source/WebCore/html/LinkRelAttribute.h:
(WebCore::operator==): Deleted.
(WebCore::operator!=): Deleted.


  Commit: cfec77a805321a4d55954f0c7466f4f8c34a2f29
      https://github.com/WebKit/WebKit/commit/cfec77a805321a4d55954f0c7466f4f8c34a2f29
  Author: Philippe Normand <philn at igalia.com>
  Date:   2022-09-07 (Wed, 07 Sep 2022)

  Changed paths:
    M Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp

  Log Message:
  -----------
  Merge 254223 at main - [GStreamer] WebAudio drums demo makes WebKit GStreamer based ports crash
https://bugs.webkit.org/show_bug.cgi?id=244841

Reviewed by Xabier Rodriguez-Calvar.

The main issue was a mix-up between channel index and channel types. The m_buffers hash table stores
buffers by channel type, so when we need to copy the data to the bus, we need to use
AudioBus::channelByType().

* Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::channelTypeFromCaps):
(WebCore::AudioFileReader::handleSample):
(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::createBus):

Canonical link: https://commits.webkit.org/254223@main

(cherry picked from commit 2aa13bb90ada0abbfe5ec6e6ad1fcc95c798a361)


Compare: https://github.com/WebKit/WebKit/compare/3af6801f2d57...cfec77a80532