[webkit-changes] [WebKit/WebKit] 2aa13b: [GStreamer] WebAudio drums demo makes WebKit GStre...

[Philippe Normand]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2aa13bb90ada0abbfe5ec6e6ad1fcc95c798a361
      https://github.com/WebKit/WebKit/commit/2aa13bb90ada0abbfe5ec6e6ad1fcc95c798a361
  Author: Philippe Normand <philn at igalia.com>
  Date:   2022-09-07 (Wed, 07 Sep 2022)

  Changed paths:
    M Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp

  Log Message:
  -----------
  [GStreamer] WebAudio drums demo makes WebKit GStreamer based ports crash
https://bugs.webkit.org/show_bug.cgi?id=244841

Reviewed by Xabier Rodriguez-Calvar.

The main issue was a mix-up between channel index and channel types. The m_buffers hash table stores
buffers by channel type, so when we need to copy the data to the bus, we need to use
AudioBus::channelByType().

* Source/WebCore/platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(WebCore::channelTypeFromCaps):
(WebCore::AudioFileReader::handleSample):
(WebCore::AudioFileReader::handleNewDeinterleavePad):
(WebCore::AudioFileReader::createBus):

Canonical link: https://commits.webkit.org/254223@main