[webkit-changes] [WebKit/WebKit] 2c362f: Merge 254097 at main - [GLIB] WheelEvent (phase=ended...
Pablo Saavedra
noreply at github.com
Mon Sep 5 00:54:08 PDT 2022
Branch: refs/heads/webkitgtk/2.36
Home: https://github.com/WebKit/WebKit
Commit: 2c362f9d4e6bfef9697e8001146be9a303fe8188
https://github.com/WebKit/WebKit/commit/2c362f9d4e6bfef9697e8001146be9a303fe8188
Author: Pablo Saavedra <psaavedra at igalia.com>
Date: 2022-09-05 (Mon, 05 Sep 2022)
Changed paths:
M Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp
Log Message:
-----------
Merge 254097 at main - [GLIB] WheelEvent (phase=ended) has to be relayed to the scrollingTree if user scroll is in progress
https://bugs.webkit.org/show_bug.cgi?id=244635
... allow the scrollingTree to finish with an possible kinetic animation
being calculated if that is the case.
Reviewed by Adrian Perez de Castro.
* Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:
(WebKit::EventDispatcher::internalWheelEvent):
Canonical link: https://commits.webkit.org/254097@main
(cherry picked from commit a1f7dcfc9842ecb6d5d73df41036fc985edb9589)
Commit: d0bb974a2906195fb2b7eb824d694dd0baab12dd
https://github.com/WebKit/WebKit/commit/d0bb974a2906195fb2b7eb824d694dd0baab12dd
Author: Pablo Saavedra <psaavedra at igalia.com>
Date: 2022-09-05 (Mon, 05 Sep 2022)
Changed paths:
M Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp
Log Message:
-----------
Merge 254099 at main - [WPE] Kinetic scrolling doesn't work in overflow scrolling
https://bugs.webkit.org/show_bug.cgi?id=234433
This extends the fix applied on bug 223133 "[GTK] Kinetic iframe async
scrolling does not work" [1] to the rest of the ports using nicosia.
For WPE (libwpe), the end of momentum scroll event can scroll contents even if
with a delta of 0. The explanation is in the implementation of the libwpe
'handle_axis_event()' API method in /Source/WebKit/UIProcess/API/wpe/WPEView.cpp:
We treat an axis motion event with a value of zero to be equivalent to a 'stop'
event. Motion events with zero motion don't exist naturally,
so this allows a backend to express 'stop' events without changing API.
The wheel event phase is adjusted accordingly.
[1] https://bugs.webkit.org/show_bug.cgi?id=223133
Reviewed by Carlos Garcia Campos.
* Source/WebCore/page/scrolling/ScrollingTreeScrollingNode.cpp:
(WebCore::ScrollingTreeScrollingNode::eventCanScrollContents const):
Canonical link: https://commits.webkit.org/254099@main
(cherry picked from commit 431d9f7c6bc7092deb4ed41cbd61d27833e6223c)
Compare: https://github.com/WebKit/WebKit/compare/57f7e7965046...d0bb974a2906
More information about the webkit-changes
mailing list