[webkit-changes] [WebKit/WebKit] 4367e1: SharedMemoryCocoa contains redundant logging

Kimmo Kinnunen noreply at github.com
Mon Sep 5 00:27:09 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4367e110706c3fcf737d42837bcb0609b047d6f7
      https://github.com/WebKit/WebKit/commit/4367e110706c3fcf737d42837bcb0609b047d6f7
  Author: Kimmo Kinnunen <kkinnunen at apple.com>
  Date:   2022-09-05 (Mon, 05 Sep 2022)

  Changed paths:
    M Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp

  Log Message:
  -----------
  SharedMemoryCocoa contains redundant logging
https://bugs.webkit.org/show_bug.cgi?id=244605
rdar://problem/99384111

Reviewed by Antti Koivisto.

Remove the duplicated RELEASE_LOG_ERROR and LOG_ERROR
by using RELEASE_LOG_ERROR and PUBLIC_LOG_STRING.
RELEASE_LOG_ERROR uses LOG_ERROR when RELEASE_LOG_DISABLED
is defined. PUBLIC_LOG_STRING format string specifier
enables the same code to be used.

* Source/WebKit/Platform/cocoa/SharedMemoryCocoa.cpp:
(WebKit::SharedMemory::Handle::takeOwnershipOfMemory const):
(WebKit::SharedMemory::Handle::setOwnershipOfMemory const):
(WebKit::SharedMemory::allocate):
(WebKit::makeMemoryEntry):
(WebKit::SharedMemory::map):
(WebKit::SharedMemory::~SharedMemory):

Canonical link: https://commits.webkit.org/254158@main




More information about the webkit-changes mailing list