[webkit-changes] [WebKit/WebKit] e2e7f8: WebFullScreenManager should not call forceRepaintW...

Simon Fraser noreply at github.com
Sat Sep 3 12:11:11 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: e2e7f87dcce6fa2f4d3c70c5a2f462774d1ade71
      https://github.com/WebKit/WebKit/commit/e2e7f87dcce6fa2f4d3c70c5a2f462774d1ade71
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2022-09-03 (Sat, 03 Sep 2022)

  Changed paths:
    M Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp
    M Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp

  Log Message:
  -----------
  WebFullScreenManager should not call forceRepaintWithoutCallback()
https://bugs.webkit.org/show_bug.cgi?id=244720

Reviewed by Jer Noble.

WebFullScreenManager is the only place that forceRepaintWithoutCallback() is called outside
of testing code. It's trying to make sure that layers are updated before the fullscreen
animation runs, but we can achieve that more cleanly using m_page.callAfterNextPresentationUpdate()
on the UI-process side.

Tested manually on youtube.com on macOS and iPad.

* Source/WebKit/UIProcess/WebFullScreenManagerProxy.cpp:
(WebKit::WebFullScreenManagerProxy::beganEnterFullScreen):
* Source/WebKit/WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::willEnterFullScreen):

Canonical link: https://commits.webkit.org/254132@main




More information about the webkit-changes mailing list