[webkit-changes] [WebKit/WebKit] 1aeb33: Support InputEvent.isComposing

Ryosuke Niwa noreply at github.com
Sat Sep 3 10:53:50 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1aeb3328d18ee0392e7a2942315d06cbbdc1b0e6
      https://github.com/WebKit/WebKit/commit/1aeb3328d18ee0392e7a2942315d06cbbdc1b0e6
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-09-03 (Sat, 03 Sep 2022)

  Changed paths:
    M LayoutTests/fast/events/input-event-insert-replacement-expected.txt
    M LayoutTests/fast/events/input-event-insert-replacement.html
    M LayoutTests/fast/events/input-events-drag-and-drop-expected.txt
    M LayoutTests/fast/events/input-events-drag-and-drop.html
    M LayoutTests/fast/events/input-events-fired-when-typing-expected.txt
    M LayoutTests/fast/events/input-events-fired-when-typing.html
    M LayoutTests/fast/events/input-events-forecolor-data-expected.txt
    M LayoutTests/fast/events/input-events-forecolor-data.html
    M LayoutTests/fast/events/input-events-ime-composition-expected.txt
    M LayoutTests/fast/events/input-events-ime-composition.html
    M LayoutTests/fast/events/input-events-ime-recomposition-expected.txt
    M LayoutTests/fast/events/input-events-ime-recomposition.html
    M LayoutTests/fast/events/input-events-insert-by-drop.html
    M LayoutTests/fast/events/input-events-typing-data-expected.txt
    M LayoutTests/fast/events/input-events-typing-data.html
    M LayoutTests/imported/w3c/web-platform-tests/uievents/constructors/inputevent-constructor-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/uievents/idlharness.window-expected.txt
    M Source/WebCore/dom/InputEvent.cpp
    M Source/WebCore/dom/InputEvent.h
    M Source/WebCore/dom/InputEvent.idl
    M Source/WebCore/editing/CompositeEditCommand.cpp
    M Source/WebCore/editing/CompositeEditCommand.h
    M Source/WebCore/editing/EditCommand.cpp
    M Source/WebCore/editing/EditCommand.h
    M Source/WebCore/editing/Editor.cpp
    M Source/WebCore/editing/TypingCommand.cpp
    M Source/WebCore/editing/TypingCommand.h

  Log Message:
  -----------
  Support InputEvent.isComposing
https://bugs.webkit.org/show_bug.cgi?id=170414

Reviewed by Wenson Hsieh.

Add isComposing boolean to InputEvent and InputEventInit.

* LayoutTests/fast/events/input-event-insert-replacement-expected.txt:
* LayoutTests/fast/events/input-event-insert-replacement.html:
* LayoutTests/fast/events/input-events-drag-and-drop-expected.txt:
* LayoutTests/fast/events/input-events-drag-and-drop.html:
* LayoutTests/fast/events/input-events-fired-when-typing-expected.txt:
* LayoutTests/fast/events/input-events-fired-when-typing.html:
* LayoutTests/fast/events/input-events-forecolor-data-expected.txt:
* LayoutTests/fast/events/input-events-forecolor-data.html:
* LayoutTests/fast/events/input-events-ime-composition-expected.txt:
* LayoutTests/fast/events/input-events-ime-composition.html:
* LayoutTests/fast/events/input-events-ime-recomposition-expected.txt:
* LayoutTests/fast/events/input-events-ime-recomposition.html:
* LayoutTests/fast/events/input-events-insert-by-drop.html:
* LayoutTests/fast/events/input-events-typing-data-expected.txt:
* LayoutTests/fast/events/input-events-typing-data.html:
* LayoutTests/imported/w3c/web-platform-tests/uievents/constructors/inputevent-constructor-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/uievents/idlharness.window-expected.txt:

* Source/WebCore/dom/InputEvent.cpp:
(WebCore::InputEvent::create):
(WebCore::InputEvent::InputEvent):
* Source/WebCore/dom/InputEvent.h:
* Source/WebCore/dom/InputEvent.idl:
* Source/WebCore/editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::isInputMethodComposing const): Added.
* Source/WebCore/editing/CompositeEditCommand.h:
* Source/WebCore/editing/EditCommand.cpp:
(WebCore::isInputMethodComposingForEditingAction): Added.
* Source/WebCore/editing/EditCommand.h:
* Source/WebCore/editing/Editor.cpp:
(WebCore::dispatchBeforeInputEvent):
(WebCore::dispatchInputEvent):
(WebCore::Editor::applyStyle):
(WebCore::Editor::applyParagraphStyle):
(WebCore::dispatchBeforeInputEvents):
(WebCore::dispatchInputEvents):
(WebCore::Editor::willApplyEditing):
(WebCore::Editor::appliedEditing):
(WebCore::Editor::willUnapplyEditing const):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::willReapplyEditing const):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::setBaseWritingDirection):
* Source/WebCore/editing/TypingCommand.cpp:
(WebCore::TypingCommand::isInputMethodComposing const): Added.
* Source/WebCore/editing/TypingCommand.h:

Canonical link: https://commits.webkit.org/254131@main




More information about the webkit-changes mailing list