[webkit-changes] [WebKit/WebKit] 51613a: [JSC][armv7] Use register numbers, not names, in d...

[jjgriego]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 51613ad86d5893667dd02bcdc0430f542f766fb9
      https://github.com/WebKit/WebKit/commit/51613ad86d5893667dd02bcdc0430f542f766fb9
  Author: Joseph Griego <jgriego at igalia.com>
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
    M Source/JavaScriptCore/disassembler/CapstoneDisassembler.cpp

  Log Message:
  -----------
  [JSC][armv7] Use register numbers, not names, in disassembly
https://bugs.webkit.org/show_bug.cgi?id=246708

Reviewed by Yusuke Suzuki.

As title. Capstone by default will use the conventional names for some registers
under the usual ARM abi: e.g. r12 is the "InterProcedural link" register, `ip`,
and r11 is `fp` for ARM code...

Neither of these makes any sense inside of the JIT, which uses r12 as a GPR and
r7 as the frame pointer (like other thumb code does.) To alleviate confusion, I
suggest we ask capstone to just use register numbers for these. Note that `pc`
and `sp` are always named in the ISA, they don't have numbers at all, so they'll
still disassemble as `pc` and `sp`.

* Source/JavaScriptCore/disassembler/CapstoneDisassembler.cpp:
(JSC::tryToDisassemble):

Canonical link: https://commits.webkit.org/256113@main