[webkit-changes] [WebKit/WebKit] 4a1a50: nullptr crash in WebCore::IDBTransaction::dispatch...

[Miguel Salinas]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4a1a50028375e15290414aa3f750adf95e9fe6ee
      https://github.com/WebKit/WebKit/commit/4a1a50028375e15290414aa3f750adf95e9fe6ee
  Author: Miguel Salinas <miguel_salinas at apple.com>
  Date:   2022-10-28 (Fri, 28 Oct 2022)

  Changed paths:
    A LayoutTests/storage/indexeddb/crash-on-getdatabases-expected.txt
    A LayoutTests/storage/indexeddb/crash-on-getdatabases.html
    A LayoutTests/storage/indexeddb/resources/crash-on-getdatabases.js
    M Source/WebCore/Modules/indexeddb/IDBTransaction.cpp

  Log Message:
  -----------
  nullptr crash in WebCore::IDBTransaction::dispatchEvent
https://bugs.webkit.org/show_bug.cgi?id=246706
rdar://94637046

Reviewed by Sihui Liu.

We should check if m_openDBRequest is null in
IDBTransaction::dispatchEvent. The repro is flaky but does reproduce for
me ~1/3 of the time. I tried to reduce the test case but it either
stopped reproducing or reproduced significantly less frequently.

* LayoutTests/storage/indexeddb/crash-on-getdatabases-expected.txt: Added.
* LayoutTests/storage/indexeddb/crash-on-getdatabases.html: Added.
* LayoutTests/storage/indexeddb/resources/crash-on-getdatabases.js: Added.
(async testDoesNotCrash):
* Source/WebCore/Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::dispatchEvent):

Canonical link: https://commits.webkit.org/256112@main