[webkit-changes] [WebKit/WebKit] 98e13f: CSSStyleValue.parse() should throw when passed an ...

Chris Dumez noreply at github.com
Wed Oct 26 07:56:03 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 98e13fd6a1c257a63bb5be5ddf8b9be9d87f602f
      https://github.com/WebKit/WebKit/commit/98e13fd6a1c257a63bb5be5ddf8b9be9d87f602f
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-10-26 (Wed, 26 Oct 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parse-invalid-expected.txt
    M LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-invalid-expected.txt
    M Source/WebCore/css/typedom/CSSStyleValueFactory.cpp

  Log Message:
  -----------
  CSSStyleValue.parse() should throw when passed an empty string as custom property value
https://bugs.webkit.org/show_bug.cgi?id=247026

Reviewed by Geoffrey Garen.

CSSStyleValue.parse() / CSSStyleValue.parseAll() should throw when passed an
empty string as custom property value.

This matches Blink's behavior and this behavior is covered by WPT tests.

* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parse-invalid-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/css/css-typed-om/stylevalue-objects/parseAll-invalid-expected.txt:
* Source/WebCore/css/typedom/CSSStyleValueFactory.cpp:
(WebCore::CSSStyleValueFactory::extractCustomCSSValues):

Canonical link: https://commits.webkit.org/256011@main




More information about the webkit-changes mailing list