[webkit-changes] [WebKit/WebKit] b902c3: HashMapStylePropertyMap is readonly and shouldn't ...

Chris Dumez noreply at github.com
Wed Oct 26 07:57:24 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: b902c3b0e0c7e62d8bdf627e5acee6b9cf7acaa4
      https://github.com/WebKit/WebKit/commit/b902c3b0e0c7e62d8bdf627e5acee6b9cf7acaa4
  Author: Chris Dumez <cdumez at apple.com>
  Date:   2022-10-26 (Wed, 26 Oct 2022)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    A Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp
    A Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.h
    M Source/WebCore/css/typedom/StylePropertyMap.cpp
    M Source/WebCore/css/typedom/StylePropertyMap.h
    M Source/WebCore/html/CustomPaintImage.cpp

  Log Message:
  -----------
  HashMapStylePropertyMap is readonly and shouldn't be subclassing StylePropertyMap
https://bugs.webkit.org/show_bug.cgi?id=247012

Reviewed by Youenn Fablet.

HashMapStylePropertyMap is readonly and shouldn't be subclassing StylePropertyMap.
Instead, introduce a MainThreadStylePropertyMapReadonly and have both
HashMapStylePropertyMap and StylePropertyMap subclass it.

* Source/WebCore/Sources.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.cpp: Copied from Source/WebCore/css/typedom/StylePropertyMap.cpp.
(WebCore::MainThreadStylePropertyMapReadOnly::documentFromContext):
(WebCore::MainThreadStylePropertyMapReadOnly::get const):
(WebCore::MainThreadStylePropertyMapReadOnly::getAll const):
(WebCore::MainThreadStylePropertyMapReadOnly::has const):
(WebCore::MainThreadStylePropertyMapReadOnly::shorthandPropertyValue const):
* Source/WebCore/css/typedom/MainThreadStylePropertyMapReadOnly.h: Copied from Source/WebCore/css/typedom/StylePropertyMap.h.
* Source/WebCore/css/typedom/StylePropertyMap.cpp:
(WebCore::StylePropertyMap::documentFromContext): Deleted.
(WebCore::StylePropertyMap::shorthandPropertyValue const): Deleted.
(WebCore::StylePropertyMap::get const): Deleted.
(WebCore::StylePropertyMap::getAll const): Deleted.
(WebCore::StylePropertyMap::has const): Deleted.
* Source/WebCore/css/typedom/StylePropertyMap.h:
* Source/WebCore/html/CustomPaintImage.cpp:

Canonical link: https://commits.webkit.org/256012@main




More information about the webkit-changes mailing list