[webkit-changes] [WebKit/WebKit] 2fe239: Do not use the CoreAnimation big angle workaround ...

Martin Robinson noreply at github.com
Wed Oct 19 01:41:41 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 2fe23935f668aa88a1b91623645ff85fa9c86d15
      https://github.com/WebKit/WebKit/commit/2fe23935f668aa88a1b91623645ff85fa9c86d15
  Author: Martin Robinson <mrobinson at webkit.org>
  Date:   2022-10-19 (Wed, 19 Oct 2022)

  Changed paths:
    M Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp

  Log Message:
  -----------
  Do not use the CoreAnimation big angle workaround for 2d rotation
https://bugs.webkit.org/show_bug.cgi?id=243864

Reviewed by Antoine Quint.

This workaround is only necessary for 3d rotation. It seems that large
angles are handled just fine for simpler 2d rotation. In addition to
allowing hardware animation in more cases, this fixes a regression due
to the software fallback path having a bug that prevents proper
rendering of certain animations.

This change does not come with any tests, due to the fact that the
typical technique of setting the animation delay to observe the
rendering in the middle of the animation does not trigger the bug.
In a sense, this change is just a partial revert of the fix from bug
250920.

* Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::hasBig3DRotation):
(WebCore::GraphicsLayerCA::createTransformAnimationsFromKeyframes):
(WebCore::hasBigRotationAngle): Deleted.

Canonical link: https://commits.webkit.org/255723@main




More information about the webkit-changes mailing list