[webkit-changes] [WebKit/WebKit] 8df966: AsyncScrolling: add ScrollingTreePositionedNode ba...

Carlos Garcia Campos noreply at github.com
Wed Oct 19 01:52:27 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8df9660de3fcb9c1cd5b79bee37a9f39662caf79
      https://github.com/WebKit/WebKit/commit/8df9660de3fcb9c1cd5b79bee37a9f39662caf79
  Author: Carlos Garcia Campos <cgarcia at igalia.com>
  Date:   2022-10-19 (Wed, 19 Oct 2022)

  Changed paths:
    M Source/WebCore/Sources.txt
    M Source/WebCore/SourcesCocoa.txt
    M Source/WebCore/SourcesGTK.txt
    M Source/WebCore/SourcesWPE.txt
    M Source/WebCore/WebCore.xcodeproj/project.pbxproj
    M Source/WebCore/page/scrolling/ScrollingTreeNode.h
    A Source/WebCore/page/scrolling/ScrollingTreePositionedNode.cpp
    A Source/WebCore/page/scrolling/ScrollingTreePositionedNode.h
    M Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNode.mm
    R Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNode.h
    R Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNode.mm
    A Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNodeCocoa.h
    A Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNodeCocoa.mm
    M Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm
    M Source/WebCore/page/scrolling/nicosia/ScrollingTreeFixedNode.cpp
    M Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp
    R Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.cpp
    R Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.h
    A Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNodeNicosia.cpp
    A Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNodeNicosia.h
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp
    M Source/WebKit/UIProcess/RemoteLayerTree/ios/RemoteScrollingCoordinatorProxyIOS.mm

  Log Message:
  -----------
  AsyncScrolling: add ScrollingTreePositionedNode base class
https://bugs.webkit.org/show_bug.cgi?id=246453

Reviewed by Žan Doberšek.

Make Cocoa and Nicosia implementations inherit from the base class and move the common code there.

* Source/WebCore/Sources.txt:
* Source/WebCore/SourcesCocoa.txt:
* Source/WebCore/SourcesGTK.txt:
* Source/WebCore/SourcesWPE.txt:
* Source/WebCore/WebCore.xcodeproj/project.pbxproj:
* Source/WebCore/page/scrolling/ScrollingTreePositionedNode.cpp: Renamed from Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNode.mm.
(WebCore::ScrollingTreePositionedNode::commitStateBeforeChildren):
(WebCore::ScrollingTreePositionedNode::scrollDeltaSinceLastCommit const):
* Source/WebCore/page/scrolling/ScrollingTreePositionedNode.h: Copied from Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNode.h.
* Source/WebCore/page/scrolling/cocoa/ScrollingTreeFixedNode.mm:
(WebCore::ScrollingTreeFixedNode::applyLayerPositions):
* Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNodeCocoa.h: Renamed from Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNode.h.
(WebCore::ScrollingTreePositionedNodeCocoa::layer const):
* Source/WebCore/page/scrolling/cocoa/ScrollingTreePositionedNodeCocoa.mm: Added.
(WebCore::ScrollingTreePositionedNodeCocoa::create):
(WebCore::ScrollingTreePositionedNodeCocoa::ScrollingTreePositionedNodeCocoa):
(WebCore::ScrollingTreePositionedNodeCocoa::commitStateBeforeChildren):
(WebCore::ScrollingTreePositionedNodeCocoa::applyLayerPositions):
* Source/WebCore/page/scrolling/mac/ScrollingTreeMac.mm:
(ScrollingTreeMac::createScrollingTreeNode):
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeFixedNode.cpp:
(WebCore::ScrollingTreeFixedNode::applyLayerPositions):
* Source/WebCore/page/scrolling/nicosia/ScrollingTreeNicosia.cpp:
(WebCore::ScrollingTreeNicosia::createScrollingTreeNode):
* Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNodeNicosia.cpp: Renamed from Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.cpp.
(WebCore::ScrollingTreePositionedNodeNicosia::create):
(WebCore::ScrollingTreePositionedNodeNicosia::ScrollingTreePositionedNodeNicosia):
(WebCore::ScrollingTreePositionedNodeNicosia::commitStateBeforeChildren):
(WebCore::ScrollingTreePositionedNodeNicosia::applyLayerPositions):
* Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNodeNicosia.h: Renamed from Source/WebCore/page/scrolling/nicosia/ScrollingTreePositionedNode.h.
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteScrollingTree.cpp:
(WebKit::RemoteScrollingTree::createScrollingTreeNode):

Canonical link: https://commits.webkit.org/255724@main




More information about the webkit-changes mailing list