[webkit-changes] [WebKit/WebKit] 1f023f: [LFC][IFC] Fix fast/block/float/floats-offset-imag...

[Alan Baradlay]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 1f023fa75e143cdc2eaff4c4f54c2cf04cb4066b
      https://github.com/WebKit/WebKit/commit/1f023fa75e143cdc2eaff4c4f54c2cf04cb4066b
  Author: Alan Bujtas <zalan at apple.com>
  Date:   2022-10-14 (Fri, 14 Oct 2022)

  Changed paths:
    A LayoutTests/fast/block/float/tall-line-vs-intrusive-floats-quirks-mode-expected.html
    A LayoutTests/fast/block/float/tall-line-vs-intrusive-floats-quirks-mode.html
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.cpp
    M Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.h

  Log Message:
  -----------
  [LFC][IFC] Fix fast/block/float/floats-offset-image-quirk-lineheight.html
https://bugs.webkit.org/show_bug.cgi?id=246424

Reviewed by Antti Koivisto.

The initial line height in quirks mode (where there's no imaginary strut on the line) is 0.
It fixes inline content positioning when intrusive floats are present, where the inline content (e.g. <img>)
is not as tall as the computed line height.

 ----                                      ----
|    |                                    |    |   -----
|    |                     vs.            |    |  | img |
 ----             -----                    ----    -----
 --------------  | img |                   -------------
|              |  -----                   |             |
 --------------                            -------------

^^ tall line prevents us from placing the <img> next to the upper float box.

* LayoutTests/fast/block/float/tall-line-vs-intrusive-floats-quirks-mode-expected.html: Added.
* LayoutTests/fast/block/float/tall-line-vs-intrusive-floats-quirks-mode.html: Added.
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingGeometry.cpp:
(WebCore::Layout::InlineFormattingGeometry::initialLineHeight const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.cpp:
(WebCore::Layout::InlineFormattingQuirks::initialLineHeight const):
* Source/WebCore/layout/formattingContexts/inline/InlineFormattingQuirks.h:

Canonical link: https://commits.webkit.org/255566@main