[webkit-changes] [WebKit/WebKit] 8574b9: [WebInspector] Display OpenGL object ids in canvas...

Dan Glastonbury noreply at github.com
Fri Oct 14 18:00:16 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8574b90773edf4ffb2bd7f9c5fd1b361cef52360
      https://github.com/WebKit/WebKit/commit/8574b90773edf4ffb2bd7f9c5fd1b361cef52360
  Author: Dan Glastonbury <djg at apple.com>
  Date:   2022-10-14 (Fri, 14 Oct 2022)

  Changed paths:
    M LayoutTests/inspector/canvas/recording-webgl-full-expected.txt
    M LayoutTests/inspector/canvas/recording-webgl-snapshots-expected.txt
    M LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-full-expected.txt
    M LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-snapshots-expected.txt
    M LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-full-expected.txt
    M LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-snapshots-expected.txt
    M Source/WebCore/inspector/InspectorCanvas.cpp
    M Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.css
    M Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js

  Log Message:
  -----------
  [WebInspector] Display OpenGL object ids in canvas inspector
https://bugs.webkit.org/show_bug.cgi?id=246186
rdar://problem/100875691
Reviewed by Devin Rousso and Dean Jackson.

Record the underlying OpenGL object id associated with each WebGL object and
display these ids along with the WebGL object type in WebInspector canvas
inspector mode to aid determining which objects are being referred to in the
call trace.

* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-full-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl-snapshots-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-full-expected.txt:
* LayoutTests/platform/mac-wk1/inspector/canvas/recording-webgl2-snapshots-expected.txt:
* Source/WebCore/inspector/InspectorCanvas.cpp:
(WebCore::InspectorCanvas::processArgument):
* Source/WebInspectorUI/UserInterface/Views/RecordingActionTreeElement.js:
(WI.RecordingActionTreeElement._generateDOM.createParameterElement):
(WI.RecordingActionTreeElement._generateDOM):

Canonical link: https://commits.webkit.org/255565@main




More information about the webkit-changes mailing list