[webkit-changes] [WebKit/WebKit] c0048e: Add margin when comptuing baseline position for ta...

Sammy Gill noreply at github.com
Mon Oct 10 11:15:52 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: c0048e83eb237ba2dba8a01bfc46bf0de42412a2
      https://github.com/WebKit/WebKit/commit/c0048e83eb237ba2dba8a01bfc46bf0de42412a2
  Author: Sammy Gill <sammy.gill at apple.com>
  Date:   2022-10-10 (Mon, 10 Oct 2022)

  Changed paths:
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/inline-table-inline-block-baseline-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/inline-table-inline-block-baseline-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/inline-table-inline-block-baseline-vert-rl-expected.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/inline-table-inline-block-baseline-vert-rl-ref.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/inline-table-inline-block-baseline-vert-rl.html
    A LayoutTests/imported/w3c/web-platform-tests/css/css-align/baseline-rules/inline-table-inline-block-baseline.html
    M Source/WebCore/rendering/RenderTable.cpp

  Log Message:
  -----------
  Add margin when comptuing baseline position for tables.
https://bugs.webkit.org/show_bug.cgi?id=97239
rdar://problem/100910532

Reviewed by Brent Fulgham.

After computing the baseline of a table, we need to take into
consideration any margins that are shifting the element. Without adding
the margin to the baseline, any items that are basline against the table
may become offset by that amount.

* Source/WebCore/rendering/RenderTable.cpp:
(WebCore::RenderTable::baselinePosition const):

Canonical link: https://commits.webkit.org/255357@main




More information about the webkit-changes mailing list