[webkit-changes] [WebKit/WebKit] 263b32: Have the DrawingAreaProxy control `delegatesScroll...

Simon Fraser noreply at github.com
Mon Oct 10 11:09:35 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 263b327294f3c5e15fe23efd03d499cde6284569
      https://github.com/WebKit/WebKit/commit/263b327294f3c5e15fe23efd03d499cde6284569
  Author: Simon Fraser <simon.fraser at apple.com>
  Date:   2022-10-10 (Mon, 10 Oct 2022)

  Changed paths:
    M Source/WebKit/UIProcess/API/mac/WKContentViewMac.mm
    M Source/WebKit/UIProcess/DrawingAreaProxy.h
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h
    M Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm
    M Source/WebKit/UIProcess/WebPageProxy.cpp
    M Source/WebKit/UIProcess/WebPageProxy.h
    M Source/WebKit/UIProcess/ios/WKContentView.mm

  Log Message:
  -----------
  Have the DrawingAreaProxy control `delegatesScrolling` in the UI process
https://bugs.webkit.org/show_bug.cgi?id=246243
rdar://100924685

Reviewed by Chris Dumez.

Move the notion of `delegatesScrolling` from WebPageProxy to DrawingAreaProxy, since this is presentation-related.
This was only actually used in RemoteLayerTreeDrawingAreaProxy to control the indicator position, but future patches will make more use of it.

Also have the DrawingAreaProxy be the factory for the RemoteScrollingCoordinatorProxy.

* Source/WebKit/UIProcess/API/mac/WKContentViewMac.mm:
(-[WKContentView initWithFrame:page:]): No need to call setDelegatesScrolling(); this is derived from the DrawingAreaProxy.
* Source/WebKit/UIProcess/DrawingAreaProxy.h:
(WebKit::DrawingAreaProxy::usesDelegatedScrolling const):
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.h:
* Source/WebKit/UIProcess/RemoteLayerTree/RemoteLayerTreeDrawingAreaProxy.mm:
(WebKit::RemoteLayerTreeDrawingAreaProxy::createScrollingCoordinatorProxy const):
(WebKit::RemoteLayerTreeDrawingAreaProxy::indicatorLocation const): RemoteLayerTreeDrawingAreaProxy always uses delegated scrolling so remove the condition.
(WebKit::RemoteLayerTreeDrawingAreaProxy::updateDebugIndicator): Ditto
* Source/WebKit/UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setDrawingArea):
* Source/WebKit/UIProcess/WebPageProxy.h:
* Source/WebKit/UIProcess/ios/WKContentView.mm:
(-[WKContentView _commonInitializationWithProcessPool:configuration:]): No need to call setDelegatesScrolling(); this is derived from the DrawingAreaProxy.

Canonical link: https://commits.webkit.org/255356@main




More information about the webkit-changes mailing list