[webkit-changes] [WebKit/WebKit] 5af403: MouseEventInit should take movementX and movementY

Ryosuke Niwa noreply at github.com
Fri Oct 7 22:21:40 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 5af403b8e2fc6e12b7eae64adab29805fbea0fd3
      https://github.com/WebKit/WebKit/commit/5af403b8e2fc6e12b7eae64adab29805fbea0fd3
  Author: Ryosuke Niwa <rniwa at webkit.org>
  Date:   2022-10-07 (Fri, 07 Oct 2022)

  Changed paths:
    M LayoutTests/imported/w3c/web-platform-tests/pointerlock/constructor-expected.txt
    M LayoutTests/pointer-lock/mouse-event-api-expected.txt
    M LayoutTests/pointer-lock/mouse-event-api.html
    M Source/WebCore/dom/DragEvent.cpp
    M Source/WebCore/dom/DragEvent.h
    M Source/WebCore/dom/MouseEvent.cpp
    M Source/WebCore/dom/MouseEvent.h
    M Source/WebCore/dom/MouseEvent.idl
    M Source/WebCore/dom/MouseEventInit.idl
    M Source/WebCore/dom/MouseRelatedEvent.cpp
    M Source/WebCore/dom/MouseRelatedEvent.h
    M Source/WebCore/dom/PointerEvent.cpp
    M Source/WebCore/dom/SimulatedClick.cpp
    M Source/WebCore/dom/WheelEvent.cpp
    M Source/WebCore/page/EventHandler.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm
    M Source/WebKitLegacy/mac/WebView/WebPDFView.mm

  Log Message:
  -----------
  MouseEventInit should take movementX and movementY
https://bugs.webkit.org/show_bug.cgi?id=246067

Reviewed by Chris Dumez.

Added movementX and movementY to MouseEventInit and made them double instead of LayoutUnit
to match the latest specification:
https://w3c.github.io/pointerlock/#extensions-to-the-mouseevent-interface

* LayoutTests/imported/w3c/web-platform-tests/pointerlock/constructor-expected.txt:
* LayoutTests/pointer-lock/mouse-event-api-expected.txt:
* LayoutTests/pointer-lock/mouse-event-api.html:
* Source/WebCore/dom/DragEvent.cpp:
(WebCore::DragEvent::create):
(WebCore::DragEvent::DragEvent):
* Source/WebCore/dom/DragEvent.h:
* Source/WebCore/dom/MouseEvent.cpp:
(WebCore::MouseEvent::create):
(WebCore::MouseEvent::MouseEvent):
* Source/WebCore/dom/MouseEvent.h:
* Source/WebCore/dom/MouseEvent.idl:
* Source/WebCore/dom/MouseEventInit.idl:
* Source/WebCore/dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):
* Source/WebCore/dom/MouseRelatedEvent.h:
(WebCore::MouseRelatedEvent::movementX const):
(WebCore::MouseRelatedEvent::movementY const):
* Source/WebCore/dom/PointerEvent.cpp:
(WebCore::PointerEvent::PointerEvent):
* Source/WebCore/dom/SimulatedClick.cpp:
* Source/WebCore/dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent):
(WebCore::m_underlyingPlatformEvent): Deleted.
* Source/WebCore/page/EventHandler.cpp:
(WebCore::EventHandler::dispatchDragEvent):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::navigateToPDFLinkWithSimulatedClick):
* Source/WebKitLegacy/ios/WebView/WebPDFViewPlaceholder.mm:
(-[WebPDFViewPlaceholder simulateClickOnLinkToURL:]):
* Source/WebKitLegacy/mac/WebView/WebPDFView.mm:
(-[WebPDFView PDFViewWillClickOnLink:withURL:]):

Canonical link: https://commits.webkit.org/255309@main




More information about the webkit-changes mailing list