[webkit-changes] [WebKit/WebKit] fa25b1: KeyframeEffect::setAnimation should clear blending...

[Frédéric Wang]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fa25b1316fbd386c2ab617f9a3a3cfe1c22d22c8
      https://github.com/WebKit/WebKit/commit/fa25b1316fbd386c2ab617f9a3a3cfe1c22d22c8
  Author: Frédéric Wang <fred.wang at free.fr>
  Date:   2022-10-07 (Fri, 07 Oct 2022)

  Changed paths:
    M Source/WebCore/animation/KeyframeEffect.cpp

  Log Message:
  -----------
  KeyframeEffect::setAnimation should clear blending key frames for an old CSSAnimation
https://bugs.webkit.org/show_bug.cgi?id=246244

Reviewed by Antoine Quint.

KeyframeEffect::propertyAffectingKeyframeResolutionDidChange performs a switch on m_blendingKeyframesSource but this one is no longer valid if the animation has changed.
For CSSTransition this is a no-op and for WebAnimation this is just a call to clearBlendingKeyframes(), so wrong behavior can only happen with CSSAnimation.

* Source/WebCore/animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::setAnimation): Clear blending key frames if the old animation was a CSSAnimation to prevent any misbehavior in later calls to propertyAffectingKeyframeResolutionDidChange.

Canonical link: https://commits.webkit.org/255308@main