[webkit-changes] [WebKit/WebKit] 6c771a: [run-benchmark] Allow the user to override the pla...

Carlos Alberto Lopez Perez noreply at github.com
Tue Nov 29 18:59:15 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 6c771a444c0ead2ef921346bbb9505fecf58a06a
      https://github.com/WebKit/WebKit/commit/6c771a444c0ead2ef921346bbb9505fecf58a06a
  Author: Carlos Alberto Lopez Perez <clopez at igalia.com>
  Date:   2022-11-29 (Tue, 29 Nov 2022)

  Changed paths:
    M Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py
    M Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py
    M Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py
    M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py
    M Tools/Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py

  Log Message:
  -----------
  [run-benchmark] Allow the user to override the plan timeout value via an optional --timeout parameter
https://bugs.webkit.org/show_bug.cgi?id=248498

Reviewed by Dewei Zhu.

This adds an optional '--timeout' parameter to the run-benchmark
and browserperfdash-benchmark scripts that allows the user to
specify a custom timeout value that overrides the default timeout
for the test plan.

This is useful when testing on slow devices (like a RPi).

* Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py:
(BenchmarkRunner.__init__):
* Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py:
(config_argument_parser):
(run_benchmark_plan):
* Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner.__init__):
* Tools/Scripts/webkitpy/browserperfdash/browserperfdash_runner.py:
(parse_args):
(BrowserPerfDashRunner.run):
* Tools/Scripts/webkitpy/browserperfdash/browserperfdash_unittest.py:
(FakeBenchmarkRunner.__init__):
(BrowserPerfDashRunnerTest.test_can_construct_runner_object_minimum_parameters):

Canonical link: https://commits.webkit.org/257155@main




More information about the webkit-changes mailing list