[webkit-changes] [WebKit/WebKit] ee768c: imported/w3c/web-platform-tests/fetch/stale-while-...
Ryan Reno
noreply at github.com
Tue Nov 29 18:21:22 PST 2022
Branch: refs/heads/main
Home: https://github.com/WebKit/WebKit
Commit: ee768c0b2c5815e09934e3e4588e64a687878ba8
https://github.com/WebKit/WebKit/commit/ee768c0b2c5815e09934e3e4588e64a687878ba8
Author: Ryan Reno <rreno at apple.com>
Date: 2022-11-29 (Tue, 29 Nov 2022)
Changed paths:
M LayoutTests/TestExpectations
M LayoutTests/imported/w3c/web-platform-tests/fetch/stale-while-revalidate/revalidate-not-blocked-by-csp-expected.txt
M LayoutTests/imported/w3c/web-platform-tests/fetch/stale-while-revalidate/revalidate-not-blocked-by-csp.html
Log Message:
-----------
imported/w3c/web-platform-tests/fetch/stale-while-revalidate/revalidate-not-blocked-by-csp.html times out
https://bugs.webkit.org/show_bug.cgi?id=248424
rdar://102734100
Reviewed by Brent Fulgham.
This test times out for all browsers because of a bug in how the Count header value is incremented.
The server backed by fetch/stale-while-revalidate/resources/stale-image.py will
only increment the count value it stores if the request URL does not contain a `query` URL
query parameter. The first time the server gets a request (when the image is first loaded) the URL
does not contain that parameter and so it increments count. However, when we poll the server in
the while loop we always call fetch with a URL that contains the `query` parameter. This caused the
server to never increment the counter and so we time out waiting for the fetch response headers to
contain Count: 2.
This fixes that bug by adding a boolean which causes us to poll the server with the `query` parameter
every other time around the loop.
* LayoutTests/TestExpectations:
* LayoutTests/imported/w3c/web-platform-tests/fetch/stale-while-revalidate/revalidate-not-blocked-by-csp-expected.txt:
* LayoutTests/imported/w3c/web-platform-tests/fetch/stale-while-revalidate/revalidate-not-blocked-by-csp.html:
Canonical link: https://commits.webkit.org/257154@main
More information about the webkit-changes
mailing list