[webkit-changes] [WebKit/WebKit] 9b7512: [JSC] reading scratch-buffer is not pure-function ...

[Yusuke Suzuki]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9b75120909b05dd982e390289ea1f137ec4a43be
      https://github.com/WebKit/WebKit/commit/9b75120909b05dd982e390289ea1f137ec4a43be
  Author: Yusuke Suzuki <ysuzuki at apple.com>
  Date:   2022-11-28 (Mon, 28 Nov 2022)

  Changed paths:
    M Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp

  Log Message:
  -----------
  [JSC] reading scratch-buffer is not pure-function call
https://bugs.webkit.org/show_bug.cgi?id=248453
rdar://102120764

Reviewed by Mark Lam.

We should not use callWithoutSideEffects for operationArithMinMultipleDouble / operationArithMaxMultipleDouble
calls since they read ScratchBuffer memory, thus they are not pure functions. They depend on content of ScratchBuffer.
So, even if ScratchBuffer's address is the same, then the result depends on its content. Use vmCall instead.

* Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileArithMinOrMax):

Canonical link: https://commits.webkit.org/257102@main