[webkit-changes] [WebKit/WebKit] 8537f7: Media fullscreen banner showing when gesture is di...

Dean Jackson noreply at github.com
Mon Nov 28 19:11:33 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 8537f74a00cdbcc63ca53257f9924200e8214319
      https://github.com/WebKit/WebKit/commit/8537f74a00cdbcc63ca53257f9924200e8214319
  Author: Dean Jackson <dino at apple.com>
  Date:   2022-11-28 (Mon, 28 Nov 2022)

  Changed paths:
    M Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm

  Log Message:
  -----------
  Media fullscreen banner showing when gesture is disabled
https://bugs.webkit.org/show_bug.cgi?id=248441
rdar://101917160

Reviewed by Eric Carlson.

We currently show a banner explaining the gesture to get out of
fullscreen on iOS. However, certain build configurations do not
support that gesture, so make the banner conditional on that
compile flag.

* Source/WebKit/UIProcess/ios/fullscreen/WKFullScreenViewController.mm:
(-[WKFullScreenViewController invalidate]):
(-[WKFullScreenViewController showBanner]):
(-[WKFullScreenViewController hideBanner]):
(-[WKFullScreenViewController setLocation:]):
(-[WKFullScreenViewController loadView]):

Canonical link: https://commits.webkit.org/257101@main




More information about the webkit-changes mailing list