[webkit-changes] [WebKit/WebKit] 138c1e: Uninitialized memory read when opening web inspector

Michael Catanzaro noreply at github.com
Thu Nov 24 07:46:17 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 138c1e2a317b66c5c8dded5735c717fc53eca62f
      https://github.com/WebKit/WebKit/commit/138c1e2a317b66c5c8dded5735c717fc53eca62f
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
    M Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h

  Log Message:
  -----------
  Uninitialized memory read when opening web inspector
https://bugs.webkit.org/show_bug.cgi?id=248293

Reviewed by Yusuke Suzuki.

WebPageInspectorController::m_enabledBrowserAgent is mistakenly not
initialized to anything. It's initialized by
InspectorBrowserAgent::enable and InspectorBrowserAgent::disable, but
these functions both first check whether it's enabled before they do
anything. That's undefined behavior. Fix is simple: initialize it.

* Source/WebKit/UIProcess/Inspector/WebPageInspectorController.h:

Canonical link: https://commits.webkit.org/256990@main




More information about the webkit-changes mailing list