[webkit-changes] [WebKit/WebKit] 4b2445: REGRESSION(256902 at main): [WPE] Broke context-menu ...

Michael Catanzaro noreply at github.com
Thu Nov 24 07:57:46 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 4b24459ebb4af8ba7b6547991d14194c4f13de31
      https://github.com/WebKit/WebKit/commit/4b24459ebb4af8ba7b6547991d14194c4f13de31
  Author: Michael Catanzaro <mcatanzaro at redhat.com>
  Date:   2022-11-24 (Thu, 24 Nov 2022)

  Changed paths:
    M Source/WebKit/PlatformWPE.cmake
    M Source/WebKit/SourcesWPE.txt
    M Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp
    M Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp
    A Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE1.cpp
    A Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE2.cpp

  Log Message:
  -----------
  REGRESSION(256902 at main): [WPE] Broke context-menu signal
https://bugs.webkit.org/show_bug.cgi?id=248243

Reviewed by Carlos Garcia Campos.

256902 at main accidentally broke WPE's WebKitWebView::context-menu signal.
After that commit, the signal declaration now has two parameters, but
the signal emission has three parameters. Instead, the original API
needs to have three parameters, while the new API can have just two
parameters. This means WebKitWebViewWPE needs to be split into multiple
files.

* Source/WebKit/PlatformWPE.cmake:
* Source/WebKit/SourcesWPE.txt:
* Source/WebKit/UIProcess/API/glib/WebKitWebView.cpp:
(webkitWebViewPopulateContextMenu):
* Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE.cpp:
(createContextMenuSignal): Deleted.
* Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE1.cpp: Added.
(createContextMenuSignal):
* Source/WebKit/UIProcess/API/wpe/WebKitWebViewWPE2.cpp: Added.
(createContextMenuSignal):

Canonical link: https://commits.webkit.org/256991@main




More information about the webkit-changes mailing list