[webkit-changes] [WebKit/WebKit] 3be2c0: Fix expected, actual links for variant-based impor...

Philippe Normand noreply at github.com
Tue Nov 15 11:22:36 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 3be2c0d6c2ab7ebbf322a81a391cd2627c687d77
      https://github.com/WebKit/WebKit/commit/3be2c0d6c2ab7ebbf322a81a391cd2627c687d77
  Author: Philippe Normand <philn at igalia.com>
  Date:   2022-11-15 (Tue, 15 Nov 2022)

  Changed paths:
    M LayoutTests/fast/harness/results.html
    M Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py
    M Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py

  Log Message:
  -----------
  Fix expected, actual links for variant-based imported wpt tests
https://bugs.webkit.org/show_bug.cgi?id=238832
<rdar://problem/91313891>

Reviewed by Jonathan Bedard.

Ensure that the workaround involving "len(fs.splitext(output_basename)[1]) - 1 > 5"
does not affect imported templated wpt tests that may match that condition, such as
".../pbkdf2.https.any.worker.html."

A unittest for SVG results was added as well, since the initial patch was reverted due to this case.

Based on rolled out patch authored by J Pascoe  <j_pascoe at apple.com>.

* LayoutTests/fast/harness/results.html:
* Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(TestResultWriter.output_filename):
* Tools/Scripts/webkitpy/layout_tests/controllers/test_result_writer_unittest.py:
(TestResultWriterTest.test_output_filename):
(TestResultWriterTest):
(TestResultWriterTest.test_output_filename_worker_variant):
(TestResultWriterTest.test_output_filename_variant):
(TestResultWriterTest.test_output_svg_filename):

Canonical link: https://commits.webkit.org/256703@main




More information about the webkit-changes mailing list