[webkit-changes] [WebKit/WebKit] fd6f66: font-variant-alternates list support and case-inse...

[Matthieu Dubet]

  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: fd6f66d0417561831691ccd5ea165b4062f7f4f4
      https://github.com/WebKit/WebKit/commit/fd6f66d0417561831691ccd5ea165b4062f7f4f4
  Author: Matthieu Dubet <m_dubet at apple.com>
  Date:   2022-11-15 (Tue, 15 Nov 2022)

  Changed paths:
    M LayoutTests/TestExpectations
    M LayoutTests/platform/gtk/TestExpectations
    M Source/WTF/wtf/text/WTFString.cpp
    M Source/WTF/wtf/text/WTFString.h
    M Source/WebCore/css/CSSFontSelector.cpp
    M Source/WebCore/css/CSSFontSelector.h
    M Source/WebCore/css/parser/CSSPropertyParser.cpp
    M Source/WebCore/platform/text/TextFlags.cpp
    M Source/WebCore/platform/text/TextFlags.h
    M Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp

  Log Message:
  -----------
  font-variant-alternates list support and case-insensitivity
https://bugs.webkit.org/show_bug.cgi?id=246811
rdar://101638181

https://www.w3.org/TR/css-fonts-4/#font-variant-alternates-prop

CSS "character-variant" and "styleset" support a list of
feature names in CSS. Before this patch, only a single feature name was supported.

This patch also contains a change to make font family name matching
case insensitive for "@font-feature-values" at-rule.

Reviewed by Darin Adler.

* LayoutTests/TestExpectations:

The alternates-order.html layout test contains 9 specific tests related to font variant.
This patch fixes the remaining 2 out of 9 which were failing:
  - one because of the case-sensitivity in font name matching.
  - another because of the missing support for list value.

* LayoutTests/platform/gtk/TestExpectations:
* Source/WTF/wtf/text/WTFString.cpp:
(WTF::makeStringByJoining):
* Source/WTF/wtf/text/WTFString.h:
* Source/WebCore/css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFeatureValuesRule):
(WebCore::CSSFontSelector::lookupFontFeatureValues):
* Source/WebCore/css/CSSFontSelector.h:
* Source/WebCore/css/parser/CSSPropertyParser.cpp:
(WebCore::consumeFontVariantAlternates):
* Source/WebCore/platform/text/TextFlags.cpp:
(WebCore::operator<<):
(WebCore::computeFeatureSettingsFromVariants):
* Source/WebCore/platform/text/TextFlags.h:
* Tools/TestWebKitAPI/Tests/WTF/WTFString.cpp:
(TestWebKitAPI::TEST):

Canonical link: https://commits.webkit.org/256702@main