[webkit-changes] [WebKit/WebKit] 9eeab8: Remove InjectedBundlePagePolicyClient

EWS noreply at github.com
Wed Nov 9 10:44:25 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/WebKit/WebKit
  Commit: 9eeab8da91f070e26e251a4e8b853e844eeb2410
      https://github.com/WebKit/WebKit/commit/9eeab8da91f070e26e251a4e8b853e844eeb2410
  Author: Alex Christensen <achristensen at webkit.org>
  Date:   2022-11-09 (Wed, 09 Nov 2022)

  Changed paths:
    M LayoutTests/fast/encoding/mailto-always-utf-8-expected.txt
    M LayoutTests/fast/forms/mailto/formenctype-attribute-button-html-expected.txt
    M LayoutTests/fast/forms/mailto/formenctype-attribute-input-2-expected.txt
    M LayoutTests/fast/forms/mailto/formenctype-attribute-input-html-expected.txt
    M LayoutTests/fast/loader/onload-policy-ignore-for-frame-async-delegates.html
    M LayoutTests/fast/loader/onload-policy-ignore-for-frame.html
    M LayoutTests/fast/loader/policy-delegate-action-hit-test-zoomed-expected.txt
    M LayoutTests/http/tests/download/basic-ascii.html
    M LayoutTests/http/tests/download/literal-utf-8.html
    M LayoutTests/http/tests/misc/policy-delegate-called-twice-expected.txt
    M LayoutTests/http/tests/misc/resources/iframe-policy-1.html
    A LayoutTests/platform/mac-wk1/fast/encoding/mailto-always-utf-8-expected.txt
    A LayoutTests/platform/mac-wk1/fast/forms/mailto/formenctype-attribute-button-html-expected.txt
    A LayoutTests/platform/mac-wk1/fast/forms/mailto/formenctype-attribute-input-2-expected.txt
    A LayoutTests/platform/mac-wk1/fast/forms/mailto/formenctype-attribute-input-html-expected.txt
    A LayoutTests/platform/mac-wk1/fast/loader/policy-delegate-action-hit-test-zoomed-expected.txt
    A LayoutTests/platform/mac-wk1/http/tests/misc/policy-delegate-called-twice-expected.txt
    A LayoutTests/platform/win/fast/encoding/mailto-always-utf-8-expected.txt
    A LayoutTests/platform/win/fast/forms/mailto/formenctype-attribute-button-html-expected.txt
    A LayoutTests/platform/win/fast/forms/mailto/formenctype-attribute-input-2-expected.txt
    A LayoutTests/platform/win/fast/forms/mailto/formenctype-attribute-input-html-expected.txt
    A LayoutTests/platform/win/fast/loader/policy-delegate-action-hit-test-zoomed-expected.txt
    A LayoutTests/platform/win/http/tests/misc/policy-delegate-called-twice-expected.txt
    M Source/WebKit/Sources.txt
    M Source/WebKit/UIProcess/API/C/WKFrameInfoRef.cpp
    M Source/WebKit/UIProcess/API/C/WKFrameInfoRef.h
    M Source/WebKit/UIProcess/API/C/WKNavigationActionRef.cpp
    M Source/WebKit/UIProcess/API/C/WKNavigationActionRef.h
    M Source/WebKit/UIProcess/API/C/WKNavigationResponseRef.cpp
    M Source/WebKit/UIProcess/API/C/WKNavigationResponseRef.h
    M Source/WebKit/WebKit.xcodeproj/project.pbxproj
    M Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp
    R Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp
    R Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h
    M Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.cpp
    M Source/WebKit/WebProcess/WebPage/WebPage.h
    M Tools/TestWebKitAPI/Tests/WebKitObjC/CustomProtocolsInvalidScheme_Bundle.cpp
    M Tools/WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp
    M Tools/WebKitTestRunner/InjectedBundle/InjectedBundlePage.h
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp
    M Tools/WebKitTestRunner/InjectedBundle/TestRunner.h
    M Tools/WebKitTestRunner/TestController.cpp
    M Tools/WebKitTestRunner/TestController.h
    M Tools/WebKitTestRunner/TestInvocation.cpp

  Log Message:
  -----------
  Remove InjectedBundlePagePolicyClient
https://bugs.webkit.org/show_bug.cgi?id=247169
rdar://101655797

Reviewed by Tim Horton.

There was one layout test, fast/loader/policy-delegate-action-hit-test-zoomed.html,
which printed the dom node path of the clicked link.  This functionality is not available
nor needed in WK2.  The WK1 test still verifies it.  WK2 has _WKHitTestResult with tests
to verify we get the node info we need in this case.

* Source/WebKit/Sources.txt:
* Source/WebKit/WebKit.xcodeproj/project.pbxproj:
* Source/WebKit/WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetPolicyClient):
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.cpp: Removed.
* Source/WebKit/WebProcess/InjectedBundle/InjectedBundlePagePolicyClient.h: Removed.
* Source/WebKit/WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForResponse):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebKit::WebFrameLoaderClient::dispatchUnableToImplementPolicy):
* Source/WebKit/WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::close):
(WebKit::WebPage::initializeInjectedBundlePolicyClient): Deleted.
* Source/WebKit/WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleLoaderClient):
(WebKit::WebPage::injectedBundlePolicyClient): Deleted.

Canonical link: https://commits.webkit.org/256491@main




More information about the webkit-changes mailing list